Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information on the TLS properties to the filtering log #1171

Closed
ameshkov opened this issue Oct 31, 2019 · 5 comments
Closed

Add more information on the TLS properties to the filtering log #1171

ameshkov opened this issue Oct 31, 2019 · 5 comments

Comments

@ameshkov
Copy link
Member

This might require adding a new callback (onSessionStarted or smth like this).
Or we could simply pass it to onBeforeRequest?

Here's what makes sense to add there:

  1. TLS version
  2. Selected cipher
  3. Original certificate (I know we're going to expose it through the browser assistant, but having it in the log is also useful)

What else?

@sfionov
Copy link
Member

sfionov commented Oct 31, 2019

IMHO displaying selected cipher in browser assistant will be useful too, because browsers shows that.

@ameshkov
Copy link
Member Author

Well, we can simply use the same cipher for the browser<->AG connection

@sfionov
Copy link
Member

sfionov commented Oct 31, 2019

Well, we can simply use the same cipher for the browser<->AG connection

We don't generate ECDSA certs for now, so it will not be easy.

@ameshkov
Copy link
Member Author

Ah, makes sense

@billkewl
Copy link

Is Adguard able to generate ECDSA certs now? after CoreLibs ver. 1.15.25?
#360

If so. How to regenerate a new cert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment