Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML requests are not displayed in the filtering log if there is a rule with$generichide modifier #5213

Open
4 tasks done
AdamWr opened this issue Aug 13, 2024 · 0 comments
Open
4 tasks done

Comments

@AdamWr
Copy link
Member

AdamWr commented Aug 13, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard version

7.18.0 nightly 12 (4793) (CL 1.16.8, DL 2.5.38 )

Browser version

127

OS version

Windows 11

Traffic filtering

  • yes, I do

Ad Blocking

AdGuard Base filter

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Other

No response

Language-specific

No response

Which DNS server do you use?

DNS protection disabled

DNS protocol

None

Custom DNS

No response

What Stealth Mode options do you have enabled?

No response

Support ticket ID

No response

Issue Details

Steps to reproduce:

  1. Enable Base filter and add this rule to user rules:
example.org#%#AG_onLoad((function(){const e=document.createElement("div");e.innerHTML='<iframe width="560" height="315" src="https://www.youtube.com/embed/55UrUXJG4Ig?si=g7tmkWp2l60Y_h16" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" referrerpolicy="strict-origin-when-cross-origin" allowfullscreen></iframe>',document.body.appendChild(e)}));
  1. Open filtering log and check to log only HTML requests
  2. Go to - https://example.org/

Expected Behavior

A rule from first step adds YouTube iframe to website and it should be visible in the filtering log (like on the screenshot below, it's from 7.17.2 version).

Screenshot

image

Actual Behavior

Iframe (youtube.com/embed/) is not visible in the filtering log if there is $generichide rule.

Screenshot

image

If I add:

@@||www.youtube.com^$generichide,badfilter

to user rules then iframe is displayed correctly.

Screenshot

image

Screenshots

No response

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants