Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to operate the dialog boxes using the Space bar #4677

Closed
contribucious opened this issue Apr 16, 2023 · 1 comment
Closed

Comments

@contribucious
Copy link

contribucious commented Apr 16, 2023

💻 Version 7.13 nightly 8 on Windows 10 Pro 22H2.

Issue Details

Hi. In the continuity of the issue Add the ability to operate the dialog boxes using Enter, I propose the same but with the Space bar.

📷 Explanatory screenshot

Firefox (JavaScript confirm prompt) ✔️ vs AdGuard (custom prompt) ✖️ …

 
26Mjecolig
↪️ Note: The Space bar also works immediately on Chromium-based browsers — i.e. without using TAB beforehand.

🎦 Animated GIF

Windows (VBScript MsgBox prompt) ✔️ vs AdGuard (custom prompt) ✖️ …

 
wy1kicnXSD
↪️ Note: Direct link to see it better.

 


🆕 Another example where the Space bar works by default (Notepad editor, regarding Yes/No/Cancel prompts):
Reveal …

 
notepad_vElDMlNZCl
Adguard_zGkr5WwhNR
↬ Note that unlike with ENTER, in these prompts too, a visually "pressed" Yes button should be visible for < 1 sec.
In the same way as when the TAB key is used beforehand.

@Aydinv13
Copy link

@contribucious Hi there!

Sounds like a good idea. We'll take a look, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants