Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DNS) Filter Editor: Can't paste using Ctrl + V under certain circumstances #4647

Open
contribucious opened this issue Mar 17, 2023 · 5 comments

Comments

@contribucious
Copy link

contribucious commented Mar 17, 2023

(:wave:) Steps to reproduce

  1. Right-click on the AdGuard systray icon > Tools > DNS filter editor.
  2. Open AdGuard DNS filter for example > select the first normal rule for example > press Ctrl + C.
  3. Open User rules > press Ctrl + V.
     

Note: Applicable also to Filter editor.

Expected behavior

Whether rules are already present (list displayed) or not (AdGuard mascot displayed), the copied rule appears.

Current behavior

Nothing happens in both of the above cases.

In fact, even after reclicking on User rules (to ensure focus) or clicking on the mascot / mascot area (second case only), no way to paste it directly (i.e. without further action).

⚙️ Workaround

  • If any rule already exists: click on one of them (or the last empty one) before …
  • If no rules exist: click in the top input field Search rule then press twice on TAB

… and only then, Ctrl + V will work.
 


💻 AdGuard 7.13 nightly 4 (latest nightly) on Windows 10 Pro 22H2 (OS Build 19045.2728)

@contribucious
Copy link
Author

💡 Bonus

Reveal …

By the way, in any writeable filter (User rules for example), it would make sense in addition to the current Copy and Cut¹, to have Paste² in the context menu. At least, if not on any entry, on the empty line located at the end of the list.

¹ Which, in my humble opinion, should be reversed, to be consistent with Windows file management (i.e. Cut and then Copy).
↪️ Also, it would be more logical: after Delete (hard) comes Cut (medium) then Copy (soft). And only then, the new Paste after that.
² And, regarding a possible additional Paste below (to paste just after a currently selected rule), it's not required IMHO as Allow to quickly reorder rules is planned.

@Aydinv13
Copy link

@contribucious Hi there!

The thing is that in addition to entering a rule, there is also a search bar in Filter editor which can be used.

@contribucious
Copy link
Author

contribucious commented Mar 28, 2023

@Aydinv13 Hello Aydin! 👋

What about limiting this Ctrl + V behavior only at the immediate opening of "User rules" / "Custom" filter? Meaning, only just after a click on the name of a writeable filter.
↪️ (Search field is not auto-focused after this action, so no problem at all. You can't type anything at this stage anyway.)

Concrete useful example:

You create a custom filter to segment your "User rules", you go to the latter to cut (Ctrl + X) some rules, then you go to your new created filter and you can paste them directly (Ctrl + V). Very easy to reorganize your rules quickly with this system. 👍

What do you think? 💭

@Aydinv13
Copy link

Aydinv13 commented Apr 5, 2023

@contribucious

Sorry for the delay, we have come to the conclusion that we can do it, but depending on how it will be coordinated with the release date of the new version (v8.0)
Assigned to v7.14.

@contribucious
Copy link
Author

@Aydinv13

Perfect! ✌️

Thank you very much! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants