Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for Deezer's desktop app(s) #3064

Open
DandelionSprout opened this issue Nov 8, 2019 · 1 comment
Open

Add full support for Deezer's desktop app(s) #3064

DandelionSprout opened this issue Nov 8, 2019 · 1 comment

Comments

@DandelionSprout
Copy link
Member

DandelionSprout commented Nov 8, 2019

I hereby request that AdGuard for Windows (and technically also AdGuard for Mac) should fully support the desktop apps of the French-run, globally-available music streaming service Deezer, in such a way that cosmetic filters and AdGuard Assistant work properly on it.

Since the desktop app uses almost exactly the same GUI as e.g. https://deezer.com/en/playlist/4419236002, I can only presume that this would indicate that the desktop app is a shell for Deezer's web interface, but don't take my word for it. Likewise, the fact the Spotify was fully supported last time I checked (which was admittedly more than 6 months ago), looks like a precedent for having AdGuard support music services.

AdGuard for Windows' support for Deezer's desktop app was always flimsy at best, but AdGuard 7 seems to have entirely removed what little support for it it ever had, judging by how the Deezer EXE file is shown in light grey in List of filtered applications.

There are two almost identical current distributions of the desktop app: A Microsoft Store version, and a regular desktop version. To download the latter, visit this page while using a Windows 7 or 8 user agent.

The Microsoft Store version in particular has the file locations change after each app update, which makes it furthermore difficult to try to add it as a custom filtered application on the user-end.

I know that you guys are pretty busy and such, but I want to get the most out of my anti-Christmas-carol list now that we're entering the season of neverending barrages of Last Christmas, Silent Night, and Deck the Halls.

Steps to reproduce

N/A

Expected behavior

The AdGuard Assistant button shows up in the lower right, elements become selectable, and cosmetic filters begin to apply.

Actual behavior

Nothing of note occurs, only blocking rules take effect, and only image/Ajax/similar log entries show up in AdGuard's logger.

Screenshot:

Comparing the browser and desktop versions of Deezer in a logged-in state:

  1. Browser:
    image

  2. Desktop (Screenshot was taken in Norwegian, as I can't find a language setting in a hurry.):
    image

Customer ID

I can't seem to find it manually, not even when extracting a ZIP log file.

Your environment

  • Environment name and version: Deezer 4.17.1, desktop version
  • Operating system and version: Windows 10 v.1903, build 18362.418
@zzebrum
Copy link
Contributor

zzebrum commented Nov 13, 2019

@DandelionSprout to implement your request we need to add a new feature that allows adding an app to be filtered as a browser.

@ameshkov ameshkov added this to the 7.6 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants