-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of the general JS api #88860
Labels
Comments
This was referenced Jul 23, 2021
Merged
This was referenced Jul 30, 2021
AdamWr
added
A: Resolved
and removed
A: In progress
Work on the issue is in progress
labels
Aug 5, 2021
Done.
|
@AdamWr let's open an issue in the scriptlets repo, we should develop a scriptlet alternative for these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Most of these functions should be replaced with scriptlets:
https://github.com/AdguardTeam/FiltersRegistry/blob/master/filters/general_js_api.js
Please check filters and get rid of these:
AG_removeElementById
AG_removeElementBySelector
AG_removeParent
AG_each
AG_removeCookie
AG_abortOnPropertyWrite
AG_abortOnPropertyRead
AG_abortInlineScript
AG_setConstant
AG_defineProperty
If there're any rules that cannot be replaced with a scriptlet, add a comment with an explanation, we'll have to come up with a feasible solution.
The text was updated successfully, but these errors were encountered: