Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A rule from a disabled filter list disables another rule #3002

Open
3 tasks done
windwak3r opened this issue Oct 15, 2024 · 0 comments
Open
3 tasks done

A rule from a disabled filter list disables another rule #3002

windwak3r opened this issue Oct 15, 2024 · 0 comments

Comments

@windwak3r
Copy link

windwak3r commented Oct 15, 2024

Please answer the following questions for yourself before submitting an issue

  • Filters were updated before reproducing an issue
  • I checked the knowledge base and found no answer
  • I checked to make sure that this issue has not already been filed

AdGuard Extension version

5.0.138

Browser version

Chrome 129

OS version

Windows 11

Ad Blocking

No response

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Other

No response

Language-specific

No response

What Tracking protection options do you have enabled?

No response

Issue Details

Initial problem: $denyallow rule doesn't work

STR:

  1. Disable all filters
  2. Go to user rules and add this rule:
$script,third-party,denyallow=authkong.com|rsc.cdn77.org|linkvertise.com|fastly.net|statically.io|sharecast.ws|b-cdn.net|bunnycdn.ru|bootstrapcdn.com|cdn.ampproject.org|cloudflare.com|cdn.staticfile.org|disqus.com|disquscdn.com|dmca.com|ebacdn.com|facebook.net|fastlylb.net|fbcdn.net|fluidplayer.com|fontawesome.com|github.io|google.com|googleapis.com|googletagmanager.com|gstatic.com|jquery.com|jsdelivr.net|jwpcdn.com|jwplatform.com|polyfill.io|recaptcha.net|shrink.pe|twitter.com|ulogin.ru|unpkg.com|userapi.com|vidazoo.com|vk.com|yastatic.net|ytimg.com|zencdn.net|youtube.com|cackle.me|googleoptimize.com|vuukle.com|chatango.com|twimg.com|google-analytics.com|hcaptcha.com|raincaptcha.com|media-imdb.com|blogger.com|hwcdn.net|instagram.com|wp.com|fastcomments.com|plyr.io|cloudflare.net|rabbitstream.net|x.com,_____,domain=igg-games.com|urlbluemedia.shop
!The rule below is needed to reproduce the problem on igg-games.com
igg-games.com#%#//scriptlet('adjust-setTimeout', 'document.createElement', '*', '0.001')
  1. Go to https://igg-games.com/beamng-drive-free-224451650-download.html, open developer tools and the filtering log.
Screenshot

Screenshot

4. Add `*` at the beginning of the first rule and check step 3 again.

Relevant issues:
AdguardTeam/AdguardFilters#190232
AdguardTeam/AdguardFilters#190887


Possible bug:

If we add these user rules:

$script,third-party,denyallow=authkong.com|rsc.cdn77.org|linkvertise.com|fastly.net|statically.io|sharecast.ws|b-cdn.net|bunnycdn.ru|bootstrapcdn.com|cdn.ampproject.org|cloudflare.com|cdn.staticfile.org|disqus.com|disquscdn.com|dmca.com|ebacdn.com|facebook.net|fastlylb.net|fbcdn.net|fluidplayer.com|fontawesome.com|github.io|google.com|googleapis.com|googletagmanager.com|gstatic.com|jquery.com|jsdelivr.net|jwpcdn.com|jwplatform.com|polyfill.io|recaptcha.net|shrink.pe|twitter.com|ulogin.ru|unpkg.com|userapi.com|vidazoo.com|vk.com|yastatic.net|ytimg.com|zencdn.net|youtube.com|cackle.me|googleoptimize.com|vuukle.com|chatango.com|twimg.com|google-analytics.com|hcaptcha.com|raincaptcha.com|media-imdb.com|blogger.com|hwcdn.net|instagram.com|wp.com|fastcomments.com|plyr.io|cloudflare.net|rabbitstream.net|x.com,_____,domain=example.org|test.com
$script,third-party,domain=test.com,badfilter

and enter the following in the console:

(() => {
    const head = document.querySelector('head');
    const script = document.createElement('script');
    script.type = 'text/javascript';
    script.src = '//test.com/f670e34470348b/48166';
    head.appendChild(script);
})();

the request won't be blocked either but if we remove $script,third-party,domain=test.com,badfilter the request will be blocked.

Screenshot

Screenshot

The only place we have the $script,third-party,domain=igg-games.com,badfilter rule is in French filter list, but at the time of the test it was disabled.

Expected Behavior

No response

Actual Behavior

The request is displayed in the filtering log as blocked, but on the Network tab of developer tools it's not.
The rule from disabled French filter interferes with another rule.

Screenshots

Screenshot 1

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants