Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist & temp disable blocking for unprivileged clients #1235

Open
rodalpho opened this issue Dec 5, 2019 · 7 comments
Open

Whitelist & temp disable blocking for unprivileged clients #1235

rodalpho opened this issue Dec 5, 2019 · 7 comments

Comments

@rodalpho
Copy link

rodalpho commented Dec 5, 2019

One major problem with DNS-based adblockers is that unprivileged clients have no way to whitelist or disable adblocking to fix page damage on their own. This responsibility all falls to the server admin, unless they give admin access to everybody.

Since AG Home has the ability to set DNS on a per-client basis, it should be possible to fix that. This would be a killer feature differentiating AGH from Pihole. My thoughts are:

  1. Client goes to "https://adguard". Ideally this would be a configurable local hostname that always works. This page is separate from the full admin site with limited privileges.

If parental control is off, this site is accessible without any authentication. Otherwise it requires a password shared between all (adult) clients.

  1. The (adult) client is permitted to white/blacklist hosts and/or disable blocking for a configurable period of time, all affecting that client only. Per-client configurations persist and are saved by MAC address.

  2. That's it!

@ameshkov
Copy link
Member

ameshkov commented Dec 8, 2019

@Archivebase this is not really a duplicate. Basically what's requested is a simplified "client" web panel where the client can change its settings (without changing the global settings).

@ghost
Copy link

ghost commented Dec 9, 2019

@ameshkov then it's a one thing explained in #997 😉

Configure administrator access to certain 'Client' #809 for manage data and change settings (change DNS #821 and filters #435 etc)

@rodalpho
Copy link
Author

rodalpho commented Dec 9, 2019

I think there is an amount of overlap, the key difference being that I didn't envision nonprivileged clients being required to create and manage a user account, instead just tracking by MAC address. These are unsophisticated users and my primary goal was to remove as much complexity as possible while allowing them to easily correct page damage.

@ghost
Copy link

ghost commented Dec 9, 2019

Usually those simple features ruin the software quality, conflict or lack compatibility for new features. Even it reduce the complexity as you expected, there are cons may lead to find alternatives with time.

Without especially point out, you mention about things belong to user account as incomplete however seems not perfect for me. that's why i explained it.

@rodalpho dont take that serious😊 just only a feedback for @ameshkov😉

@rodalpho
Copy link
Author

I don't have any real insight into where AGH is going so I can't comment on conflicts or compatibility in the future, I just described a feature that would be very useful to my users who constantly complain about page damage.

@ghost
Copy link

ghost commented Dec 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants