Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Log doesn't show date #1202

Closed
3 tasks done
Ultrabenosaurus opened this issue Nov 24, 2019 · 2 comments
Closed
3 tasks done

Query Log doesn't show date #1202

Ultrabenosaurus opened this issue Nov 24, 2019 · 2 comments

Comments

@Ultrabenosaurus
Copy link

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

Now that AGH supports logging more than 24 hours of data the Query Log should display the date as well as the time for each row, at least for any request not made on the current day. At the moment the date is only shown in a tooltip when hovering over the time no matter how wide you drag the column. In the screenshot below I have filtered the log based on the IP address of a relative's smartphone, who last visited a few days ago.

image

Proposed Solution

Show the date for requests not made on the current day or for all requests, with a default column width suitable for displaying both date and time. This could be enabled for all users or dynamic based on the chosen data retention period, e.g. it's not entirely necessary for people who have their AGH set to 24 hours.

Alternatives Considered

It may also be nice to have a toggle setting for "always show date" vs. "show date for requests not made today" so people can choose how they want it displayed. I can't speak for everybody but I would find it much easier to notice when I reach the end of today's data while flicking through my Query Log if one request only shows a time and the next also shows the date. This would be beneficial when looking for suspect, missing, or expected requests, or when investigating a sudden increase in requests.

@ghost
Copy link

ghost commented Nov 24, 2019

#624 (v0.101)

@Ultrabenosaurus
Copy link
Author

Ultrabenosaurus commented Nov 24, 2019

@Archivebase I feel that this is different now. #624 is about Chinese localisation and was opened before AGH could support more than 24 hours of log retention. Now the log can contain more than 24 hours this should be high priority.

I almost opened this as a bug instead of feature request as it feels like it was "missed" or "forgotten" when extended log retention was added. It's very annoying when viewing the Query Log, especially when filtering the data, that it is not obvious what day a request was made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants