Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds props to extend accessibility support #164

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

erichsilvestre
Copy link
Contributor

No description provided.

@zuberc-cds
Copy link

@erichsilvestre , Can this be merged please? I need this feature.

@erichsilvestre
Copy link
Contributor Author

@erichsilvestre , Can this be merged please? I need this feature.

I wish it could be.

@erichsilvestre , Can this be merged please? I need this feature.

@zuber7 I almost gave up on this MR lol.. the conflicts will be fixed today then we merge it.

@erichsilvestre
Copy link
Contributor Author

@zuber7 I have resolved the conflicts

@zuberc-cds
Copy link

@zuber7 I have resolved the conflicts

Thanks @erichsilvestre . How can this be released in a new version?

@erichsilvestre
Copy link
Contributor Author

@zuber7 I have resolved the conflicts

Thanks @erichsilvestre . How can this be released in a new version?

ask @AdeleD to merge it :D

@AdeleD
Copy link
Owner

AdeleD commented Jul 21, 2020

I'm OK to add aria-label props on previous and next buttons. But I think the other props you add in this PR (currentPageAriaLabel and pageAriaLabel) are not necessary because you could probably do something like that:

<PaginationBoxView
        initialPage={1}
        pageCount={3}
        ariaLabelBuilder={(page, selected) => selected ? 'The current page is page ' + page : 'It\'s page ' + page }
        extraAriaContext="some extra context" />
    );

@erichsilvestre
Copy link
Contributor Author

@AdeleD it was 3y ago lol. I will check it and get back to you soon.

@AdeleD
Copy link
Owner

AdeleD commented Jul 29, 2020

Sorry. And thank you.

@erichsilvestre
Copy link
Contributor Author

@AdeleD are we good to go right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants