-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds props to extend accessibility support #164
Adds props to extend accessibility support #164
Conversation
@erichsilvestre , Can this be merged please? I need this feature. |
I wish it could be.
@zuber7 I almost gave up on this MR lol.. the conflicts will be fixed today then we merge it. |
@zuber7 I have resolved the conflicts |
Thanks @erichsilvestre . How can this be released in a new version? |
ask @AdeleD to merge it :D |
I'm OK to add aria-label props on previous and next buttons. But I think the other props you add in this PR ( <PaginationBoxView
initialPage={1}
pageCount={3}
ariaLabelBuilder={(page, selected) => selected ? 'The current page is page ' + page : 'It\'s page ' + page }
extraAriaContext="some extra context" />
); |
@AdeleD it was 3y ago lol. I will check it and get back to you soon. |
Sorry. And thank you. |
194eeec
to
32f9421
Compare
@AdeleD are we good to go right now? |
No description provided.