PR changes

Author: reediculous456

README.md

@@ -18,7 +18,7 @@ or
 Install `react-paginate` with [npm](https://www.npmjs.com/):
 
 ```
-$ npm install react-paginate --save
+npm install react-paginate --save
 ```
 
 For [CommonJS](http://wiki.commonjs.org/wiki/CommonJS) users:
@@ -35,26 +35,26 @@ how to make `react-paginate` work with a list of objects.
 Clone the repository and move into:
 
 ```console
-$ git clone git@github.com:AdeleD/react-paginate.git
-$ cd react-paginate
+git clone git@github.com:AdeleD/react-paginate.git
+cd react-paginate
 ```
 
 Install dependencies:
 
 ```console
-$ make install
+make install
 ```
 
 Prepare the demo:
 
 ```console
-$ make demo
+make demo
 ```
 
 Run the server:
 
 ```console
-$ make serve
+make serve
 ```
 
 Open your browser and go to [http://localhost:3000/](http://localhost:3000/)
@@ -80,7 +80,7 @@ Open your browser and go to [http://localhost:3000/](http://localhost:3000/)
 | `containerClassName`     | `String`   | The classname of the pagination container.                                                   |
 | `pageClassName`          | `String`   | The classname on tag `li` of each page element.                                              |
 | `pageLinkClassName`      | `String`   | The classname on tag `a` of each page element.                                               |
-| `pageLabelRender`        | `Function` | Function to set the text on page links. Defaults to `(index) => index + 1`                   |
+| `pageLabelRender`        | `Function` | Function to set the text on page links. Defaults to `(page) => page`                   |
 | `activeClassName`        | `String`   | The classname for the active page.                                                           |
 | `activeLinkClassName`    | `String`   | The classname on the active tag `a`.                                                         |
 | `previousClassName`      | `String`   | The classname on tag `li` of the `previous` button.                                          |
@@ -106,7 +106,7 @@ Open your browser and go to [http://localhost:3000/](http://localhost:3000/)
 Run tests:
 
 ```console
-$ make test
+make test
 ```
 
 [1]: https://github.com/AdeleD/react-paginate/blob/master/demo/js/demo.js

__tests__/PaginationBoxView-test.js

@@ -1268,7 +1268,10 @@ describe('Test custom props', () => {
       const pagination = ReactTestUtils.renderIntoDocument(
         <PaginationBoxView
           pageCount={data.length}
-          pageLabelRender={(index) => data[index]?.name}
+          pageLabelRender={(page) => {
+            const pageIndex = page - 1;
+            return data[pageIndex]?.name
+          }}
         />
       );
 

react_components/PageView.js

@@ -54,7 +54,7 @@ const PageView = (props) => {
         onKeyPress={pageSelectedHandler}
         {...getEventListener(pageSelectedHandler)}
       >
-        {pageLabelRender(page - 1)}
+        {pageLabelRender(page)}
       </a>
     </li>
   );

react_components/PaginationBoxView.js

@@ -56,7 +56,7 @@ export default class PaginationBoxView extends Component {
     breakLabel: '...',
     disabledClassName: 'disabled',
     disableInitialCallback: false,
-    pageLabelRender: (index) => index + 1,
+    pageLabelRender: (page) => page,
     eventListener: 'onClick',
   };