forked from conventional-changelog/commitlint
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(cli): remove hard coded comment char with linting
COMMIT_EDIT_MSG
When running the cli and passing the `--edit` flag the comment char was hard coded to a `#`. Even if there is a `commentChar` set in the `parserOpts` the cli will override it with a `#`. Now the cli will only set it to a `#` if its not already set in the `parserOpts` Fixes Issue: conventional-changelog#2351
- Loading branch information
1 parent
73b2ed1
commit b7a6b7a
Showing
3 changed files
with
24 additions
and
2 deletions.
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
@commitlint/cli/fixtures/comment-char/commitlint.config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
module.exports = { | ||
rules: { | ||
'subject-empty': [2, 'never'] | ||
}, | ||
parserPreset: { | ||
parserOpts: { | ||
commentChar: '$' | ||
} | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters