-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batched inference CEBRA & padding at the Solver
level
#168
Open
CeliaBenquet
wants to merge
45
commits into
AdaptiveMotorControlLab:main
Choose a base branch
from
CeliaBenquet:batched-inference-and-padding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
283de06
first proposal for batching in tranform method
gonlairo 202e379
first running version of padding with batched inference
gonlairo 1f1989d
start tests
gonlairo 8665660
add pad_before_transform to fit function and add support for convolut…
gonlairo 8d5b114
remove print statements
gonlairo 32c5ecd
first passing test
gonlairo 9928f63
add support for hybrid models
gonlairo be5630a
rewrite transform in sklearn API
gonlairo 1300b20
baseline version of a torch.Datset
gonlairo bc6af24
move batching logic outside solver
gonlairo ec377b9
move functionality to base file in solver and separate in functions
gonlairo 6f9ca98
add test_select_model for single session
gonlairo fbe7eb4
add checks and test for _process_batch
gonlairo 463b0f8
add test_select_model for multisession
gonlairo 5219171
make self.num_sessions compatible with single session training
gonlairo f9bd1a6
improve test_batched_transform_singlesession
gonlairo e23a7ef
make it work with small batches
gonlairo 19c3f87
make test with multisession work
gonlairo 87bebac
change to torch padding
gonlairo f0303e0
add argument to sklearn api
gonlairo 8c8be85
add torch padding to _transform
gonlairo 59df402
convert to torch if numpy array as inputs
gonlairo 1aadc8b
add distinction between pad with data and pad with zeros and modify t…
gonlairo bc8ee25
differentiate between data padding and zero padding
gonlairo 5e7a14c
remove float16
gonlairo 928d882
change argument position
gonlairo 07bac1c
clean test
gonlairo 0823b54
clean test
gonlairo 9fe3af3
Fix warning
CeliaBenquet b417a23
Improve modularity remove duplicate code and todos
CeliaBenquet 83c1669
Add tests to solver
CeliaBenquet 9c46eb9
Remove unused import in solver/utils
CeliaBenquet c845ec3
Fix test plot
CeliaBenquet 9db3e37
Add some coverage
CeliaBenquet 8e5f933
Fix save/load
CeliaBenquet d08e400
Remove duplicate configure_for in multi dataset
CeliaBenquet 0c693dd
Make save/load cleaner
CeliaBenquet ae056b2
Merge branch 'main' into batched-inference-and-padding
CeliaBenquet 794867b
Fix codespell errors
CeliaBenquet 0bb6549
Fix docs compilation errors
CeliaBenquet 04a102f
Fix formatting
CeliaBenquet 7aab282
Fix extra docs errors
CeliaBenquet ffa66eb
Fix offset in docs
CeliaBenquet 7f58607
Remove attribute ref
CeliaBenquet c2544c7
Add review updates
CeliaBenquet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to the base class instead: it was defined in each child class (see in multisession dataset I also removed it, and added to the base one).