Remove space between pinned tabs and normal tabs to fix a color inconsistency#170
Open
mortie wants to merge 1 commit intoAdamXweb:masterfrom
Open
Remove space between pinned tabs and normal tabs to fix a color inconsistency#170mortie wants to merge 1 commit intoAdamXweb:masterfrom
mortie wants to merge 1 commit intoAdamXweb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a CSS rule in Firefox's
tabs.csswhich causes a space between pinned tabs and normal tabs:I don't really care about that space in itself, but it caused an annoying color inconsistency because the space has a different color than the tabs (though only in dark mode for some reason, and I don't think it was an issue before Firefox 141).
Here's a screenshot of the issue I'm talking about:
Here's a screenshot of how it looks with this change:
Maybe the most proper solution would've been to fix the background color issue, but I couldn't figure out how to do that.