Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload/automatically reload config #42

Open
AdaShoelace opened this issue Mar 31, 2020 · 2 comments
Open

Hot reload/automatically reload config #42

AdaShoelace opened this issue Mar 31, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AdaShoelace
Copy link
Owner

Hadlock should be able reload the config if the config file is modified.
This means that every change change in the config file should be applied without restart of Hadlock or require to close any other application.

Suggested method:
What the config file provided upon start using inotify and reconfigure Hadlock (during runtime) if an event indicating change to the config file is received.

@AdaShoelace AdaShoelace added enhancement New feature or request good first issue Good for newcomers labels Mar 31, 2020
@wezm
Copy link
Contributor

wezm commented Mar 31, 2020

Alacritty does this. You might able to take some inspiration from that, or even reuse the code.

https://github.com/alacritty/alacritty/blob/13eb50de799c4c6f7ebed1a7fa1ab25b378580bb/alacritty/src/config/monitor.rs

@AdaShoelace
Copy link
Owner Author

I planned to start working on this tonight so I am definitely gonna look into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants