Conversation
Contributor
Author
|
I don't know if this ready for prime time due to some limitations of the mediator that came up: Follow-up stories are here:
The first one might be a blocker for putting it on production... |
Naatan
suggested changes
Jan 15, 2021
Contributor
Naatan
left a comment
Naatan
left a comment
There was a problem hiding this comment.
Very nice work! Just one super nitpicky change.
Co-authored-by: Nathan Rijksen <nathanr@activestate.com>
Co-authored-by: Mike Drakos <miked@activestate.com>
…6449977 Add state cve report
Contributor
Author
|
I added the changes that were necessary to work with the updated mediator. Of course, this does not work yet, with the production endpoint for the mediator. |
Naatan
previously approved these changes
Feb 12, 2021
Contributor
Author
|
Took a little while until the mediator was deployed, because kubernetes ran out of some resources, but now everything seems to be working. Just need another approval for the latest additions that I had to do... |
Naatan
approved these changes
Feb 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176449951