Conversation
Naatan
suggested changes
Jan 8, 2021
Contributor
Naatan
left a comment
Naatan
left a comment
There was a problem hiding this comment.
Looks great! Just some minor stuff.
internal/runners/packages/info.go
Outdated
| if version != "" { | ||
| ingredientVersion, err = specificIngredientVersion(pkg.Ingredient.IngredientID, version) | ||
| if err != nil { | ||
| return locale.NewInputError("info_err_version_not_found", "Could not find version {{.V0}} for package {{.V1}}", version, pkgName) |
Contributor
There was a problem hiding this comment.
This should be wrapping the error
internal/runners/packages/info.go
Outdated
| } | ||
|
|
||
| for _, iv := range ingredientVersions { | ||
| if *iv.Version == version { |
internal/runners/packages/info.go
Outdated
| } | ||
| } | ||
|
|
||
| return nil, locale.NewError("err_no_ingredient_version_found", "No ingredient version found") |
Contributor
There was a problem hiding this comment.
Should probably be a input error
Naatan
approved these changes
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176192863