Skip to content

Commit 530df85

Browse files
committed
feat: use codemirror api on formatter settings page
1 parent 7854fc1 commit 530df85

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/settings/formatterSettings.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
11
import settingsPage from "components/settingsPage";
22
import appSettings from "lib/settings";
3+
import { getModes } from "../codemirror/modelist";
34

45
export default function formatterSettings(languageName) {
56
const title = strings.formatter;
67
const values = appSettings.value;
78
const { formatters } = acode;
8-
const { modes } = ace.require("ace/ext/modelist");
99

10-
const items = modes.map((mode) => {
11-
const { name, caption } = mode;
10+
// Build items from CodeMirror modelist
11+
const items = getModes().map((mode) => {
12+
const { name, caption, extensions } = mode;
1213
const formatterID = values.formatter[name] || null;
13-
const extensions = mode.extensions.split("|");
14-
const options = acode.getFormatterFor(extensions);
14+
// Only pass real extensions (skip anchored filename patterns like ^Dockerfile)
15+
const extList = String(extensions)
16+
.split("|")
17+
.filter((e) => e && !e.startsWith("^"));
18+
const options = acode.getFormatterFor(extList);
1519

1620
return {
1721
key: name,

0 commit comments

Comments
 (0)