-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for non-24 fps timecode #5
Comments
@bashesenaxis reported a version of this with #55 -- pinging him here so he can see this issue. |
I think I have some pretty good code for this in C I could port to opentime. Does anyone have good reference data to use for unit testing (i.e. a list of times or frame numbers and the timecode they should read)? |
@bashesenaxis may have some, I think he hit this while working on another bug |
The bug that I hit was in: |
@bashesenaxis can you take a look at @reinecke's fix reinecke@4bc9233 to see if this handles the frame rates you need? |
Yeah, that looks good to me. |
Opentime should support all of the standard video editing frame rates: 24, 25, 30, 48, 60 and the drop frame variants 23.98, etc.
The text was updated successfully, but these errors were encountered: