Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-24 fps timecode #5

Closed
jminor opened this issue Sep 1, 2016 · 6 comments
Closed

Support for non-24 fps timecode #5

jminor opened this issue Sep 1, 2016 · 6 comments
Assignees
Milestone

Comments

@jminor
Copy link
Collaborator

jminor commented Sep 1, 2016

Opentime should support all of the standard video editing frame rates: 24, 25, 30, 48, 60 and the drop frame variants 23.98, etc.

@ssteinbach
Copy link
Collaborator

@bashesenaxis reported a version of this with #55 -- pinging him here so he can see this issue.

@jminor jminor added this to the Alpha 4 milestone Jan 5, 2017
@reinecke
Copy link
Collaborator

reinecke commented Jan 6, 2017

I think I have some pretty good code for this in C I could port to opentime. Does anyone have good reference data to use for unit testing (i.e. a list of times or frame numbers and the timecode they should read)?

@ssteinbach
Copy link
Collaborator

@bashesenaxis may have some, I think he hit this while working on another bug

@bashesenaxis
Copy link
Contributor

The bug that I hit was in:
https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/master/opentimelineio/opentime.py#L465
where 24.0 is hard-coded. I believe that should be rate instead?
I encountered this when writing unittests for the xml adapter. The data I used was the supplied premiere_example.xml, which is at 30 fps. I haven`t done any tests with drop frame data.

@jminor
Copy link
Collaborator Author

jminor commented Apr 20, 2017

@bashesenaxis can you take a look at @reinecke's fix reinecke@4bc9233 to see if this handles the frame rates you need?

@bashesenaxis
Copy link
Contributor

Yeah, that looks good to me.
Following link is the only place I have been able to find a hard-coded rate, and this pull request fixes that.
https://github.com/PixarAnimationStudios/OpenTimelineIO/blob/master/opentimelineio/opentime.py#L493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants