[cuebot/cuegui] Protect Running and Succeeded frames against retries#1761
[cuebot/cuegui] Protect Running and Succeeded frames against retries#1761DiegoTavares wants to merge 4 commits intoAcademySoftwareFoundation:masterfrom
Conversation
Retrying running and succeeded frames can lead to incoherent states when it comes to frame-on-frame and layer-on-frame dependencies. This PR prevents such requests on cuebot and also disable the menu actions on the GUI.
DiegoTavares
requested review from
bcipriano,
lithorus and
ramonfigueiredo
as code owners
|
TBH, Not sure I'm a fan of this. I restart the frames quite often to test things in rqd. Especially when you want to compare with previous runs. Also from an artist point of view, there are numerous times where they need to restart it due to some error on the render node side that produced black frames/pixels or corrupt frames. If it was an optional thing on the cueGUI side only, it would be one thing, but this is even on the server. Keep in mind that if we need to implement a framecheck of the rendered frames, it should be possible to restart the frames. Perhaps a "cool-down" timer on the server/client would be better? |
|
I hear your concerns. It makes sense. I can see a case for retrying in these circumstances. I'm moving this PR back to draft to think of a way to accommodate this scenario. |
3 participants
Retrying running and succeeded frames can lead to incoherent states when it comes to frame-on-frame and layer-on-frame dependencies.
This PR prevents such requests on cuebot and also disable the menu actions on the GUI.