Avoid a race condition on Fixed record-length file processing. #714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark-cobrix connectors processing fixed-length files can encounter race conditions when used concurrently in multiple threads or multiple notebooks sharing the same Spark driver. This will lead to assertion error
This is because, in
buildScanForFixedLength(...)
method , the objectsqlContext.sparkContext.hadoopConfiguration
is passed to the spark methodsqlContext.sparkContext.binaryRecords(...)
insidebinaryRecords
hadoopConfiguration
is getting modified like thisconf.setInt(FixedLengthBinaryInputFormat.RECORD_LENGTH_PROPERTY, recordLength)
. When multiple threads try to modify common hadoopConfiguration, there can be a race condition.Solution: Make a local copy of hadoopConfiguration for each thread, ensuring that modifications are isolated to that thread.
Issue Ref