Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

No checkers pattern on scrollbar in previewer and other preview imprecisions #19

Closed
Anixx opened this issue Aug 11, 2022 · 16 comments
Closed

Comments

@Anixx
Copy link

Anixx commented Aug 11, 2022

In the previewer the scrollbar does not reflect the "checkers" pattern that many classic color schemes (for instance, Windows 2000/XP scheme) show. This is because the pattern is defined by two different colors, not one.

изображение

Also, notice that

  • the scrollbar in the previewer has some vertical border on the right, 1px thick that the real scrollbar lacks.

  • the menu border (even in 3D menus mode) is thinner in the previewer, it is 1px thick, while in real menus it is 2px thick and those of different colors:
    изображение

  • The 3D windows border in the previewer (of Programs Container, Active Window and MessageBox but not of Inactive Window) has a grey 1px frame that does not change color with color scheme (that is, invariable):

изображение

Also, the fonts in the previewer do not use the systemwide font smoothing settings and the window control elements (the [X], [_]) have too small font size.

@Abdelrhman-AK
Copy link
Owner

I'll work on all these issues.

  • To be honest about Fonts in the previewer that do not use the systemwide font smoothing settings and the window control elements (the [X], [_]) have too small font size:

Last year, I was coding a GUI for VB.net code that mimics exactly Windows 98 GUI for fun and I ,intentionally, made the font looks pixelated (Graphics.TextRenderingHint = TextRenderingHint.SingleBitPerPixelGridFit;) and small font size.

  • I'll add a toggle to change between ClearType and Pixelated ones if anyone loves pixels styles :)

@Anixx
Copy link
Author

Anixx commented Aug 12, 2022

I have noticed that this grey frame around windows remains grey when loading Win32 (9x) color schemes and only visible on previewer. But if to load a Win3.1 scheme (such as Arizona, where it has orange color), its color in the previewer changes from grey and they affect the color of actual active windows.
изображение
Orange frame here affects real windows, only active ones. But when a 9x scheme is loaded this frame is grey on previewer and does not affect real windows. Possibly, in 9x schemes the corresponding registry key is empty, so windows uses another color instead.

@Anixx
Copy link
Author

Anixx commented Aug 12, 2022

I'll add a toggle to change between ClearType and Pixelated ones if anyone loves pixels styles :)

Definitely, a lot of people love it, but note that there are much more fonts settings there besides smoothing enabled/disabled.

For instance, there is subpixel smoothing, greyscale smoothing and no smoothing 3-way distinction, and subpixel smoothing can be RGB and BGR. And also there are more fine ClearType adjustments.

@Anixx
Copy link
Author

Anixx commented Aug 12, 2022

In a Win32 scheme the "Active color" looks grey on the palette, and shown grey on the previewer but does not appear on the actual windows:

изображение

@Abdelrhman-AK
Copy link
Owner

I have fixed most of them, I'll rework and revise the rest of bugs, wait for the next update

  • Scrollbars depend on ButtonHighlight and ButtonFace, not scrollbar (scrollbar entry works only for Windows 9x)
  • Active Border wasn't saved to register. I fixed the bug

@Anixx
Copy link
Author

Anixx commented Aug 12, 2022

In Windows 95 the pattern also was checkers-style.

@Abdelrhman-AK
Copy link
Owner

Yup, I made the previewer with this style and removed the effect of "Scrollbar" on the previewer but kept its entry

@OrthodoxWindows
Copy link

OrthodoxWindows commented Aug 12, 2022

@Anixx

The 3D windows border in the previewer (of Programs Container, Active Window and MessageBox but not of Inactive Window) has a grey 1px frame that does not change color with color scheme (that is, invariable):

I feel like my issue #21 is partly a duplicate of what you posted (with the shading). If so, sorry for the duplicate.

@OrthodoxWindows
Copy link

OrthodoxWindows commented Aug 12, 2022

For instance, there is subpixel smoothing, greyscale smoothing and no smoothing 3-way distinction, and subpixel smoothing can be RGB and BGR. And also there are more fine ClearType adjustments.

I think for the previewer there is no need for very precise font smoothing parameters :)

@Anixx
Copy link
Author

Anixx commented Aug 12, 2022

Font smoothing (especially, subpixel) can look differently on different color backgrounds.

Also, potentially this program may include font chooser in the future, just like similar control panel applets in classic versions of Windows did.

@Anixx
Copy link
Author

Anixx commented Aug 12, 2022

Names and sizes of fonts for controls is technically a part of the "color scheme" and stored in the same place in registry.

@OrthodoxWindows
Copy link

It seems to me that the color settings are no longer stored in HKCU\Control Panel\Desktop\Colors but in HKCU\Control Panel\Colors while metrics\fonts are always stored in HKCU\Control Panel\Desktop\WindowMetrics. There are currently two very good utilities for window metrics and fonts : https://github.com/Tatsu-syo/noMeiryoUI https://github.com/Tatsu-syo/ReMetrics (just missing system font support, like in Winaero Tweaker). The main advantage of these utilities is the support of the command line (and therefore batch scripts).

@Abdelrhman-AK
Copy link
Owner

It seems to me that the color settings are no longer stored in HKCU\Control Panel\Desktop\Colors but in HKCU\Control Panel\Colors while metrics\fonts are always stored in HKCU\Control Panel\Desktop\WindowMetrics. There are currently two very good utilities for window metrics and fonts : https://github.com/Tatsu-syo/noMeiryoUI https://github.com/Tatsu-syo/ReMetrics (just missing system font support, like in Winaero Tweaker). The main advantage of these utilities is the support of the command line (and therefore batch scripts).

I'm not focusing now on fonts/metrics.. may be in the future.
If so, I will depend on these sources

@Abdelrhman-AK
Copy link
Owner

For instance, there is subpixel smoothing, greyscale smoothing and no smoothing 3-way distinction, and subpixel smoothing can be RGB and BGR. And also there are more fine ClearType adjustments.

I think for the previewer there is no need for very precise font smoothing parameters :)

I turned it to the same smoothing mode set by the user, not subpixel (To make it more close to the user)

@OrthodoxWindows
Copy link

OrthodoxWindows commented Aug 12, 2022

I'm not focusing now on fonts/metrics.. may be in the future.
If so, I will depend on these sources

In fact, I provided these links for Anixx.
It was not a request on my part.

@Abdelrhman-AK
Copy link
Owner

I'm not focusing now on fonts/metrics.. may be in the future.
If so, I will depend on these sources

In fact, I provided these links for Anixx.
It was not a request on my part.

I'm sorry, I misunderstood this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants