Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.17 #568

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Release 1.0.17 #568

merged 1 commit into from
Apr 17, 2024

Conversation

jakethekoenig
Copy link
Member

@jakethekoenig jakethekoenig commented Apr 17, 2024

Previous release wasn't released to pypi because the commit wasn't formatted correctly.

Pull Request Checklist

  • Documentation has been updated, or this change doesn't require that

Previous release wasn't released to pypi because the commit wasn't
formatted correctly.
@@ -3,7 +3,12 @@ Changelog

In this changelog focus on user facing highlights and stick to the format. This information will be used to motivate users to upgrade or after upgrading to inform them of features that might otherwise not be very discoverable.

`1.0.16 <https://pypi.org/project/mentat/1.0.15/>`__
`1.0.17 <https://pypi.org/project/mentat/1.0.17/>`__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there was a mistake in the previous version link for 1.0.16. The link points to 1.0.15 instead of 1.0.16. Please correct it to ensure accuracy.

`1.0.17 <https://pypi.org/project/mentat/1.0.17/>`__
--------------------------------------------------

- Fix requirement conflict for numpy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the nature of the fix (requirement conflict for numpy), it might be helpful for users if a bit more detail is provided. For example, specifying the versions of numpy that were conflicting or the impact it had could offer better insight into the necessity of the upgrade.

Copy link
Contributor

mentatbot bot commented Apr 17, 2024

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos.
Please Reply with feedback.

This pull request effectively updates the version and provides a concise entry in the changelog for the latest release. However, there's a minor correction needed in the version link for 1.0.16, and it could be beneficial to include more details about the numpy conflict fix to better inform users. Overall, the changes are straightforward and align with the project's versioning and documentation standards.

@jakethekoenig jakethekoenig merged commit 522107e into main Apr 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant