Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Actions ctags install issue #542

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

biobootloader
Copy link
Member

@biobootloader biobootloader commented Mar 19, 2024

ctags installs were failing on github actions macos runners. Switching from macos-latest to macos-14 seems to fix it (although I thought 14 was the latest??)

more details here: actions/runner-images#4020

Pull Request Checklist

  • Documentation has been updated, or this change doesn't require that

@biobootloader biobootloader changed the title trigger gha fail Fix Github Actions ctags install issue Mar 19, 2024
@@ -1,6 +1,7 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like an unnecessary blank line was added at the beginning of the file. This doesn't follow the usual formatting conventions and doesn't seem to serve a purpose. Consider removing it to keep the file clean and consistent.

Copy link
Contributor

mentatbot bot commented Mar 19, 2024

MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos.
Please Reply with feedback.

The changes in this pull request seem to be minor and possibly unintentional. It's important to ensure that every change serves a purpose, especially in configuration files where clarity and conciseness are key. Please review the necessity of the added blank line.

@biobootloader
Copy link
Member Author

@abanteai-butler can you review again?

@biobootloader biobootloader marked this pull request as ready for review March 19, 2024 21:32
@biobootloader biobootloader merged commit 81552b7 into main Mar 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant