Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AaronLasseigne/active_interaction
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.2
Choose a base ref
...
head repository: AaronLasseigne/active_interaction
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.3
Choose a head ref
  • 14 commits
  • 27 files changed
  • 1 contributor

Commits on Jul 15, 2013

  1. Fix #27; use RDoc instead of kramdown

    This necessitated switching from tilde code blocks (~~~) to backtick
    code blocks (```). I also switched from "rb" to "ruby" because RDoc
    claims to only support "ruby".
    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    8273810 View commit details
    Browse the repository at this point in the history
  2. Clean up readme

    `fmt` all the things!
    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    82ccc91 View commit details
    Browse the repository at this point in the history
  3. Use simpler way to set model name

    The method signature for ActiveModel::Name.new changed between
    version 3.0.9 and 3.1.0. Because of that, this test was failing for
    ActiveModel < 3.1.0.
    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    e333ffa View commit details
    Browse the repository at this point in the history
  4. Handle nil time zones

    It's possible to have Time.zone available but unconfigured, in which
    case it is nil.
    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    3abd30c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    27977b9 View commit details
    Browse the repository at this point in the history
  6. Fix a couple typos

    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    fa4a97e View commit details
    Browse the repository at this point in the history
  7. Keep lines under 80 characters

    We don't have a style guide, but I like to follow bbatsov's:
    https://github.com/bbatsov/ruby-style-guide
    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    dbbb13c View commit details
    Browse the repository at this point in the history
  8. Tidy up spec names

    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    d54f92b View commit details
    Browse the repository at this point in the history
  9. Fix minor spacing issues

    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    b3642a6 View commit details
    Browse the repository at this point in the history
  10. Clean up method_missing and friends

    In particular, filter_attr_accessor was kind of getting out of hand.
    
    I don't like how the setup helpers all take almost the same arguments.
    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    596081b View commit details
    Browse the repository at this point in the history
  11. Check for the correct method

    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    76453c4 View commit details
    Browse the repository at this point in the history
  12. Update changelog

    tfausak committed Jul 15, 2013
    Configuration menu
    Copy the full SHA
    c98b211 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2013

  1. Implement pending spec

    I finally remembered how to test blocks!
    tfausak committed Jul 16, 2013
    Configuration menu
    Copy the full SHA
    4b6a5c0 View commit details
    Browse the repository at this point in the history
  2. Release version 0.1.3

    tfausak committed Jul 16, 2013
    Configuration menu
    Copy the full SHA
    cfcb65f View commit details
    Browse the repository at this point in the history
Loading