Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrite visibility checking to be more generic/cleaner as well as add functionality to check if the element is scrolled on screen for more intuitive paste-target selection, fixes #10488
the improvement is that now we check the scroll location of viable elements when pasting an image and paste the image into the topmost element that's visible on screen, making pasted image inputs more intuitive
previously if using controlnets/segmentation etc in i2i, the pasted image would always land in the i2i input image window, now if you scroll down to controlnet such that the i2i window is no longer visible, the pasted image will end up in the controlnet input rather than the i2i input, this simplifies the use of addons that accept image input in conjunction with i2i or when using multiple addons that accept image input in t2i
i've done a bit of testing with different addons and have not found any regressions vs the previous 1.1 functionality, and this fixes an issue in 1.2 where in some circumstances pasted images would end up in a hidden pane as per #10488
Environment this was tested in
Screenshots or videos of your changes
This is not strictly a UI change as the UI still appears the exact same? I'm not sure exactly what I should provide a screenshot/video of here.