Rename verify_challenge to challenge_verify

Prefixing the box functions with the box name makes logical sense.

Author: Patater

source/box-challenge.cpp

@@ -73,7 +73,7 @@ static inline bool buffer_overlaps_box_context(const void *buffer, size_t length
             ctx_addr + ctx_length > buffer_addr);
 }
 
-UVISOR_EXTERN bool __verify_secret(const uint8_t *secret, int len)
+UVISOR_EXTERN bool __challenge_verify(const uint8_t *secret, int len)
 {
     /* We only accept calls where 'len' equals CHALLENGE_SIZE.
      * Although this creates a timing side channel which exposes the
@@ -107,9 +107,10 @@ UVISOR_EXTERN bool __verify_secret(const uint8_t *secret, int len)
     return secure_compare(secret, uvisor_ctx->secret, len);
 }
 
-bool verify_secret(const uint8_t *secret, int len)
+bool challenge_verify(const uint8_t *secret, int len)
 {
-    /* A security transition happens here. This ensures that __verify_secret()
-     * will run with the privileges of the box_challenge box. */
-    return secure_gateway(box_challenge, __verify_secret, secret, len);
+    /* A security transition happens here. This ensures that
+     * __challenge_verify() will run with the privileges of the box_challenge
+     * box. */
+    return secure_gateway(box_challenge, __challenge_verify, secret, len);
 }

source/box-challenge.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013-2015, ARM Limited, All Rights Reserved
+ * Copyright (c) 2013-2016, ARM Limited, All Rights Reserved
  * SPDX-License-Identifier: Apache-2.0
  *
  * Licensed under the Apache License, Version 2.0 (the "License"); you may
@@ -19,7 +19,7 @@
 
 #define CHALLENGE_SIZE 16
 
-extern bool verify_secret(const uint8_t *secret, int len);
+extern bool challenge_verify(const uint8_t *secret, int len);
 extern void *g_box_context;
 
 #endif/*__UVISOR_HELLOWORLD_BOX_CHALLENGE_H__*/

source/main.cpp

@@ -47,7 +47,7 @@ static void retry_secret(void)
 {
     /* Check the secret. */
     pc.printf("verifying secret...");
-    bool verified = verify_secret(g_challenge, sizeof(g_challenge));
+    bool verified = challenge_verify(g_challenge, sizeof(g_challenge));
     pc.printf(" done\n\r");
 
     /* Cancel the previous event for LED blinking. */