Skip to content

Fix USB problems on the LPC1768 #6922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2018
Merged

Fix USB problems on the LPC1768 #6922

merged 2 commits into from
Jun 11, 2018

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented May 16, 2018

Description

Implement the missing abort function and fix an error caused by not resetting data toggle.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@c1728p9
Copy link
Contributor Author

c1728p9 commented May 16, 2018

@fkjagodzinski @maciejbocianski @mmahadevan108

@c1728p9 c1728p9 mentioned this pull request May 16, 2018
Merged
@c1728p9
Copy link
Contributor Author

c1728p9 commented May 16, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 16, 2018

Test : FAILURE

Build number : 1837
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6922/1837

@0xc0170 0xc0170 requested review from maciejbocianski and a team May 18, 2018 11:01
fkjagodzinski
fkjagodzinski reviewed May 24, 2018
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked this PR against my updated tests from #6880 and I think there is something missing when reenabling endpoint interrups. When endpoint_abort() is called, and then a new interface(or altsetting) is set, the IN/OUT callbacks are not called anymore.

@c1728p9
Copy link
Contributor Author

c1728p9 commented May 27, 2018

@fkjagodzinski I updated this PR and it should resolve the problems with #6880. I tracked down the cause of the failure to disabling the endpoint event in USBEpIntEn. It had some nasty side effects causing the failure. I removed use of this and added a warning in the code.

fkjagodzinski
fkjagodzinski approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 6, 2018

Build : FAILURE

Build number : 2248
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6922/

@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

@c1728p9 Feel free to check out the build failure, but a quick look is pointing to this being an example issue, not a branch/PR issue.

@c1728p9 c1728p9 force-pushed the feature-hal-spec-usb-device branch from 675b24e to 565ec75 Compare June 6, 2018 19:48
c1728p9 added 2 commits June 6, 2018 14:58
@c1728p9
Fix LPC1768 test failures
2ad05b2 
Reset endpoints when they are removed. This ensures buffers and the
data toggle bit get reset back to zero.
@c1728p9
Implement LPC1768 USB abort function
a86d054 
Implement the USB abort function so interrupts wont fire for a
transfer that has been aborted. The transfer may still take place
but the buffer passed into endpoint_write or endpoint_read will not
be used.
@cmonr
Copy link
Contributor

cmonr commented Jun 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Build : SUCCESS

Build number : 2259
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6922/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Test : SUCCESS

Build number : 2048
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6922/2048

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Exporter Build : ABORTED

Build number : 1884
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6922/

@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

Had to stop and restart export build due to momentary IAR license issues.

@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

Halting CI builds until RC3 PRs are completed. Will resume after.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Build : SUCCESS

Build number : 2291
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6922/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Exporter Build : SUCCESS

Build number : 1915
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6922/

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Test : SUCCESS

Build number : 2069
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6922/2069

@cmonr cmonr merged commit a94b118 into ARMmbed:feature-hal-spec-usb-device Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejbocianski maciejbocianski maciejbocianski approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@c1728p9 @mbed-ci @cmonr @0xc0170 @maciejbocianski @fkjagodzinski @kjbracey