USB: Device: Fix IN and OUT callbacks #6884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not fail the assertion if no endpoints are pending when IN or OUT transmission takes place. The condition `info->pending >= 1` may be false if `endpoint_abort()` is called after the `read_start()` or `write_start()` and before the `out()` or `in()` callback.
Merged
0xc0170
approved these changes
May 14, 2018
|
If the endpoint was already aborted, whether endpoint callbacks |
c1728p9
suggested changes
May 14, 2018
|
@fkjagodzinski shall we keep this opened until new PR is up? |
@0xc0170, I don't think so. I've already talked about this with @c1728p9. This approach is not correct, the assert should stay and rather the abort function should be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not fail the assertion if no endpoints are pending when IN or OUT
transmission takes place.
The condition
info->pending >= 1may be false ifendpoint_abort()iscalled after the
read_start()orwrite_start()and before theout()orin()callback.Description
Pull request type
CC @c1728p9 @maciejbocianski @jamesbeyond