Skip to content

Separate cloud example configurations to another file #13771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

saheerb
Copy link
Contributor

@saheerb saheerb commented Oct 16, 2020

Summary of changes

This PR separate cloud examples to a separate configuration file from example configuration. This is done for the following reasons:

  • Greentea currently has a limitation as it can test example applications specified in one configuration only in a single baud rate.
  • To parallelise example application builds to improve the speed of CI pipeline

Impact of changes

None.

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

None required as changes affect CI pipeline and CI scripts are adapted for this.

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon


@0xc0170
Copy link
Contributor

0xc0170 commented Oct 16, 2020

Greentea currently has a limitation as it can test example applications specified in one configuration only in a single baud rate.

I don't follow, what limitation is this fixing by splitting the file?

To parallelise example application builds to improve the speed of CI pipeline

You can still parse json and run 2 examples at the same time or not? I dont see how splitting the json works differently than as it is.

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 16, 2020
@ciarmcom ciarmcom requested review from evedon and a team October 16, 2020 11:00
@ciarmcom
Copy link
Member

@saheerb, thank you for your changes.
@evedon @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@saheerb
Copy link
Contributor Author

saheerb commented Oct 16, 2020

I don't follow, what limitation is this fixing by splitting the file?

greentea triggers test of all the examples in one shot. It doesn't separate trigger of each examples. When baudrates are different in example-applications, greentea cannot handle this and gets executed with a single baud rate.

You can still parse json and run 2 examples at the same time or not? I dont see how splitting the json works differently than as it is.

All the examples in examples.json files are built in CI sequentially as defined in this config file. If we need to separate examples run, without touching examples.jon, we need to create another config in CI and fetch the group as needed. We could also think about moving these files to mbed-os-ci repo but I don't know how widely this is used.

Also, in CI, the way these examples are built and tested are differently to other applications. There is need to insert some certificate and connect to cloud providers.

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest

@mergify mergify bot added needs: work and removed needs: CI labels Oct 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

@saheerb Let us know once this is ready for CI (removing do not merge label)

@saheerb
Copy link
Contributor Author

saheerb commented Oct 19, 2020

@saheerb Let us know once this is ready for CI (removing do not merge label)

@0xc0170 please remove the do not merge and take necessary steps to get this merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit c6997bc into ARMmbed:master Oct 19, 2020
@mergify mergify bot removed the ready for merge label Oct 19, 2020
@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants