Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nuvoton M261 sub-family into arm_pack_manager #11171

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Add Nuvoton M261 sub-family into arm_pack_manager #11171

merged 1 commit into from
Aug 13, 2019

Conversation

cyliangtw
Copy link
Contributor

Description

According to Nuvoton.NuMicro_DFP.pdsc v1.3.4, insert Nuvoton M261 sub-family entries into arm_pack_manager.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team August 6, 2019 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 6, 2019

@cyliangtw, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Aug 9, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

I restared tests

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2019

Waiting for pr-merge fix, cc @ARMmbed/mbed-os-test

@cyliangtw cyliangtw mentioned this pull request Aug 13, 2019
Merged
@0xc0170 0xc0170 merged commit 4c1f178 into ARMmbed:master Aug 13, 2019
mark-edgeworth
mark-edgeworth reviewed Aug 13, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, although I have no way of testing whether this is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-edgeworth mark-edgeworth mark-edgeworth left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cyliangtw @ciarmcom @0xc0170 @mbed-ci @mark-edgeworth