BLE: update Cordio link layer to 19.2 #10542

paul-szczepanek-arm · 2019-05-08T08:54:23Z

Description

This depends on an updated Nordic SDK to version 15:
#9999

This updates the cordio link layer to 19.2 the release notes for which are here:
https://github.com/ARMmbed/CordioBLE-Controller-Stable/blob/master/controller/cordio_link_readme.md

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan-

Release Notes

Updates cordio link layer, doesn't change user facing API.

paul-szczepanek-arm · 2019-05-08T08:56:22Z

needs work to address Don's comments

ciarmcom · 2019-05-08T09:00:30Z

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers please review.

paul-szczepanek-arm · 2019-05-08T09:47:54Z

This is replacing the already reviewed #10272

donatieng · 2019-05-10T15:11:01Z

Hey @paul-szczepanek-arm,

@donatieng I can move the config for DK but I don't have anything to put in the configs for NRF52832 and NRF52840. Only the DK requires extra config.

Not sure what you mean - any NRF52840-based device would require that config - can you move files around accordingly?

donatieng

Approved pending Paul's ok with current re-testing

paul-szczepanek-arm · 2019-05-13T16:53:57Z

This is good to go for CI. I'm running tests in parallel.

paul-szczepanek-arm · 2019-05-14T14:13:17Z

works for 52840, not so much for 52 - need to investigate

paul-szczepanek-arm · 2019-05-16T15:38:19Z

works on nrf52, but there is a problem with the testing app so validation is based on examples

adbridge · 2019-05-17T10:15:18Z

@donatieng @pan- could one of you review the additional changes please

yogeshk19 · 2019-05-19T22:47:03Z

@adbridge I was wondering if this is on track for being rolled into 5.12.4? I am hoping this would help resolve #10321, as this issue is preventing us from testing a lot of our features.

Thanks,
Yogesh

pan- · 2019-05-20T12:45:05Z

features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/mbed_lib.json

@@ -3,7 +3,7 @@
    "config": {
        "zero-copy-hci": {
            "help": "messages sent between Host and Controller are passed directly without copying if enabled. WSF messages ownership is trasfered to the callee.",
-            "value": 0,


Is there an impact on existing targets that uses the non zero copy HCI driver ?

the zero copy is the new path, no change made for memcpy ones

0xc0170 · 2019-05-20T13:34:55Z

@adbridge I was wondering if this is on track for being rolled into 5.12.4? I am hoping this would help resolve #10321, as this issue is preventing us from testing a lot of our features.

It's functionality change, will target 5.13. @paul-szczepanek-arm correct? assuming feature branch is up to date and created against master soon

paul-szczepanek-arm · 2019-05-20T13:40:22Z

I think feature branch is just waiting on this PR.

0xc0170 · 2019-05-20T14:04:59Z

CI started

mbed-ci · 2019-05-20T18:00:41Z

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter
jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2019-05-21T09:15:46Z

CI restarted

0xc0170 · 2019-05-21T13:00:38Z

@paul-szczepanek-arm How old is the feature branch? we are getting failures I've seen previously - mismatch somewhere - I recall rebase fixed it . Can this branch be rebased? Pls write me the rebased forked, I can push it upstream.

OPpuolitaival · 2019-05-21T13:14:12Z

Seems that code is too old to support python 3

0xc0170 · 2019-05-21T13:32:01Z

we need to bring feature-nrf52-sdk15 up to date with master, that will fix CI failures here (not related at least!)

…with normal function

0xc0170 · 2019-05-24T14:23:26Z

CI started

mbed-ci · 2019-05-24T16:59:43Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

0xc0170 · 2019-05-26T17:52:32Z

Exporters restarted

yogeshk19 · 2019-06-09T22:17:53Z

@0xc0170 Is this done, is this going to be rolled into the upcoming mbed os release?

pan- · 2019-06-10T10:53:30Z

@yogeshk19 Yes that's going to be in the next release.

paul-szczepanek-arm mentioned this pull request May 8, 2019

BLE: update Cordio link layer to 19.2 #10272

Closed

ciarmcom requested review from pan- and a team May 8, 2019 09:00

ciarmcom added the needs: review label May 8, 2019

donatieng approved these changes May 10, 2019

View reviewed changes

paul-szczepanek-arm mentioned this pull request May 14, 2019

Update the Nordic nRF52 SDK 15 feature branch #10441

Merged

pan- approved these changes May 20, 2019

View reviewed changes

0xc0170 approved these changes May 20, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels May 20, 2019

0xc0170 added needs: work and removed needs: CI labels May 21, 2019

trowbridgec mentioned this pull request May 22, 2019

nRF52832 custom target and peripheral initialization problems #10562

Closed

paul-szczepanek-arm added 16 commits May 24, 2019 13:23

use TIMER2 instead

864dae7

update LL runtime config to new version

c39aeac

fix releaseing the WSF msg too early

95de5d6

review comments addressed

195da80

zero copy HCI as a config option

1b71206

configs in mbed json

ca8f1ec

removed stray comma

1dea034

remove usage of gpio and leds from nordic cordio LL as it interferes …

55dbcee

…with normal function

license updated

4ff35c7

moved config to target nordic

4ccc282

config now applies to MCU_840 instead of only DK

de61927

fix merge conflixt

ebca224

fix typo

d55ba0a

config fixed for LL hci

368231e

ifdef 52840 crypto

f497c3d

cryptocell acceleration as an option

577ba54

paul-szczepanek-arm force-pushed the cordio-link-layer branch from 0a53d7c to 577ba54 Compare May 24, 2019 12:24

0xc0170 added needs: CI release-version: feature branch and removed needs: work labels May 24, 2019

donatieng mentioned this pull request May 24, 2019

Bring Nordic SDK v15 Update to Master #10666

Merged

0xc0170 added ready for merge and removed needs: CI labels May 27, 2019

0xc0170 merged commit 9bf2d0a into ARMmbed:feature-nrf52-sdk15 May 27, 2019

0xc0170 removed the ready for merge label May 27, 2019

BLE: update Cordio link layer to 19.2 #10542

BLE: update Cordio link layer to 19.2 #10542

Uh oh!

Conversation

paul-szczepanek-arm commented May 8, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

paul-szczepanek-arm commented May 8, 2019

Uh oh!

ciarmcom commented May 8, 2019

Uh oh!

paul-szczepanek-arm commented May 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

donatieng commented May 10, 2019

Uh oh!

donatieng left a comment

Choose a reason for hiding this comment

Uh oh!

paul-szczepanek-arm commented May 13, 2019

Uh oh!

paul-szczepanek-arm commented May 14, 2019

Uh oh!

paul-szczepanek-arm commented May 16, 2019

Uh oh!

adbridge commented May 17, 2019

Uh oh!

yogeshk19 commented May 19, 2019

Uh oh!

pan- May 20, 2019

Choose a reason for hiding this comment

Uh oh!

paul-szczepanek-arm May 20, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented May 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paul-szczepanek-arm commented May 20, 2019

Uh oh!

0xc0170 commented May 20, 2019

Uh oh!

mbed-ci commented May 20, 2019

Test run: FAILED

Uh oh!

0xc0170 commented May 21, 2019

Uh oh!

0xc0170 commented May 21, 2019

Uh oh!

OPpuolitaival commented May 21, 2019

Uh oh!

0xc0170 commented May 21, 2019

Uh oh!

0xc0170 commented May 24, 2019

Uh oh!

mbed-ci commented May 24, 2019

Test run: FAILED

Uh oh!

0xc0170 commented May 26, 2019

Uh oh!

yogeshk19 commented Jun 9, 2019

Uh oh!

pan- commented Jun 10, 2019

Uh oh!

Uh oh!

paul-szczepanek-arm commented May 8, 2019 •

edited

Loading

0xc0170 commented May 20, 2019 •

edited

Loading