Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Gatt Presentation Format Descriptor class #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement Gatt Presentation Format Descriptor class #18

wants to merge 1 commit into from

Conversation

AGlass0fMilk
Copy link
Member

This commit introduces a class that simplifies the creation of a Gatt Presentation Format Descriptor. This descriptor is a Bluetooth SIG-specified descriptor type with the short-form UUID 0x2904.

See full official specification here: https://www.bluetooth.com/wp-content/uploads/Sitecore-Media-Library/Gatt/Xml/Descriptors/org.bluetooth.descriptor.gatt.characteristic_presentation_format.xml

@AGlass0fMilk AGlass0fMilk added the enhancement New feature or request label Dec 17, 2020
@AGlass0fMilk
Copy link
Member Author

Migrating this from ep-oc-mcu

paul-szczepanek-arm
paul-szczepanek-arm requested changes Dec 18, 2020
View reviewed changes
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs - > spaces.
You can have a packed struct if you want and a static assert that assures the packed size is correct.
We really need some accessible (de)serialisation utils in mbed's BLE

@pan-
Copy link
Member

pan- commented Dec 18, 2020

We really need some accessible (de)serialisation utils in mbed's BLE

Better if it was accessible to Mbed OS, we're even missing little/big endian extraction. I like the Cordio one https://github.com/ARMmbed/mbed-os/blob/master/connectivity/FEATURE_BLE/libraries/cordio_stack/wsf/include/util/bstream.h

@AGlass0fMilk
Copy link
Member Author

We really need some accessible (de)serialisation utils in mbed's BLE

Better if it was accessible to Mbed OS, we're even missing little/big endian extraction. I like the Cordio one https://github.com/ARMmbed/mbed-os/blob/master/connectivity/FEATURE_BLE/libraries/cordio_stack/wsf/include/util/bstream.h

Would like to have a class/C++ based implementation too.

@AGlass0fMilk
Implement Gatt Presentation Format Descriptor class
891609f 
This commit introduces a class that simplifies the creation of a Gatt Presentation Format Descriptor. This descriptor is a Bluetooth SIG-specified descriptor type with the short-form UUID `0x2904`.

See full official specification here: https://www.bluetooth.com/wp-content/uploads/Sitecore-Media-Library/Gatt/Xml/Descriptors/org.bluetooth.descriptor.gatt.characteristic_presentation_format.xml
@AGlass0fMilk
Copy link
Member Author

Took care of the tabs/spaces conversion and cleaned up the dead commented code.

@AGlass0fMilk AGlass0fMilk mentioned this pull request Mar 30, 2021
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm requested changes

@pan- pan- Awaiting requested review from pan-

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AGlass0fMilk @pan- @paul-szczepanek-arm