-
Notifications
You must be signed in to change notification settings - Fork 116
Add mbed-mbedtls-cryptocell310, mbed-ble-cordio_ll library #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul-szczepanek-arm if you can review what components are in BLE, that would help us. I'll need to send an email to tech leads to ask for help to improve the components (Some were created the way we looked at dir structure, so might be logically incorrect).
@@ -39,6 +39,8 @@ target_link_libraries(${APP_TARGET} | |||
mbed-ble-cordio | |||
mbed-ble-blue_nrg | |||
mbed-os-ble-utils | |||
mbed-mbedtls-cryptocell310 | |||
mbed-ble-cordio_ll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the diff between mbed-ble-cordio
and mbed-ble-cordio_ll
? I assume only one should be needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build was failed but let me try one more time without mbed-ble-cordio_ll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It expects some header files from mbed-ble-cordio_ll When I tried to build for NRF52840_DK
./mbed-os/connectivity/drivers/ble/FEATURE_BLE/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_timer.c:59:10: fatal error: sch_api.h: No such file or directory
59 | #include "sch_api.h"
| ^~~~~~~~~~~
It failed when I tried to build for K64F, If I only kept mbed-ble-cordio_ll and removed mbed-ble-cordio
gerImpl.cpp:24:
../mbed-os/connectivity/FEATURE_BLE/./source/pal/PalSecurityManager.h:29:10: fatal error: wsf_types.h: No such file or directory
29 | #include "wsf_types.h"
| ^~~~~~~~~~~~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this dep should not be fixed in our Mbed tree rather than here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cordio_ll is the link layer, it depends on the board, nrf uses it, others use the HCI driver because their link layer is provided separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed in Mbed Os. @rajkan01 please remove these and fix it in ble component.
you have to look at the json configs to see what components are used, they are different for different boards |
@paul-szczepanek-arm @0xc0170