Skip to content

Add mbed-mbedtls-cryptocell310, mbed-ble-cordio_ll library #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rajkan01
Copy link
Contributor

  • Added mbed-mbedtls-cryptocell310, mbed-ble-cordio_ll into target_link_libraries as BLE stack required

@paul-szczepanek-arm @0xc0170

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paul-szczepanek-arm if you can review what components are in BLE, that would help us. I'll need to send an email to tech leads to ask for help to improve the components (Some were created the way we looked at dir structure, so might be logically incorrect).

@@ -39,6 +39,8 @@ target_link_libraries(${APP_TARGET}
mbed-ble-cordio
mbed-ble-blue_nrg
mbed-os-ble-utils
mbed-mbedtls-cryptocell310
mbed-ble-cordio_ll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the diff between mbed-ble-cordio and mbed-ble-cordio_ll ? I assume only one should be needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build was failed but let me try one more time without mbed-ble-cordio_ll

Copy link
Contributor Author

@rajkan01 rajkan01 Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It expects some header files from mbed-ble-cordio_ll When I tried to build for NRF52840_DK

./mbed-os/connectivity/drivers/ble/FEATURE_BLE/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/stack/sources/pal_timer.c:59:10: fatal error: sch_api.h: No such file or directory
   59 | #include "sch_api.h"
      |          ^~~~~~~~~~~

It failed when I tried to build for K64F, If I only kept mbed-ble-cordio_ll and removed mbed-ble-cordio

gerImpl.cpp:24:
../mbed-os/connectivity/FEATURE_BLE/./source/pal/PalSecurityManager.h:29:10: fatal error: wsf_types.h: No such file or directory
   29 | #include "wsf_types.h"
      |          ^~~~~~~~~~~~~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this dep should not be fixed in our Mbed tree rather than here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cordio_ll is the link layer, it depends on the board, nrf uses it, others use the HCI driver because their link layer is provided separately

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed in Mbed Os. @rajkan01 please remove these and fix it in ble component.

@rajkan01 rajkan01 requested a review from 0xc0170 November 12, 2020 12:22
@paul-szczepanek-arm
Copy link
Member

you have to look at the json configs to see what components are used, they are different for different boards

@rajkan01 rajkan01 closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants