-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(crypto): multisig legacy allow signatures property #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Low
labels
Feb 12, 2020
ok so now v2 multisig registration txs are not accepted 😄 working on it |
Codecov Report
@@ Coverage Diff @@
## 2.6 #3489 +/- ##
==========================================
+ Coverage 66.17% 66.18% +<.01%
==========================================
Files 439 439
Lines 12466 12466
Branches 1710 1710
==========================================
+ Hits 8249 8250 +1
+ Misses 4183 4182 -1
Partials 34 34
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Feb 14, 2020
faustbrian
changed the title
refactor(crypto): multisig legacy allow signatures property
fix(crypto): multisig legacy allow signatures property
Feb 14, 2020
ghost
deleted the
fix/crypto/schemas-multisig-legacy
branch
February 14, 2020 04:25
ghost
mentioned this pull request
Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3444 by allowing in json schema validation legacy multisig to have the "signatures" property (which is handled fine by core then).
Checklist