Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): multisig legacy allow signatures property #3489

Merged
merged 8 commits into from
Feb 14, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Feb 12, 2020

Summary

Resolves #3444 by allowing in json schema validation legacy multisig to have the "signatures" property (which is handled fine by core then).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@air1one
Copy link
Contributor Author

air1one commented Feb 12, 2020

ok so now v2 multisig registration txs are not accepted 😄 working on it

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #3489 into 2.6 will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6    #3489      +/-   ##
==========================================
+ Coverage   66.17%   66.18%   +<.01%     
==========================================
  Files         439      439              
  Lines       12466    12466              
  Branches     1710     1710              
==========================================
+ Hits         8249     8250       +1     
+ Misses       4183     4182       -1     
  Partials       34       34
Impacted Files Coverage Δ
packages/crypto/src/transactions/registry.ts 71.05% <ø> (ø) ⬆️
packages/core-api/src/handlers/peers/controller.ts 85.1% <83.33%> (ø) ⬆️
packages/core-transaction-pool/src/storage.ts 100% <0%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa210cb...06be964. Read the comment docs.

@faustbrian faustbrian changed the title refactor(crypto): multisig legacy allow signatures property fix(crypto): multisig legacy allow signatures property Feb 14, 2020
@faustbrian faustbrian merged commit 454a125 into 2.6 Feb 14, 2020
@ghost ghost deleted the fix/crypto/schemas-multisig-legacy branch February 14, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants