Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: htlc refund handler to use performGenericWalletChecks (+ fix e2e tests) #2944

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Sep 19, 2019

HTLC refund handler needs to use performGenericWalletChecks just like claim handler.

Also fixed e2e tests (needed to give a bit more expiration time for htlc lock txs).

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

use performGenericWalletChecks instead of super.throwIfCannotBeApplied
@spkjp spkjp merged commit ec2002d into develop Sep 19, 2019
@ghost ghost deleted the test/htlc-e2e-fix branch September 19, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants