Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crypto): ensure only one signature per participant #2889

Merged
merged 2 commits into from
Aug 25, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Aug 24, 2019

Ensure a participant does not provide multiple valid signatures by himself.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

Codecov Report

Merging #2889 into develop will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2889      +/-   ##
===========================================
- Coverage     67.7%   67.69%   -0.01%     
===========================================
  Files          405      405              
  Lines         9726     9733       +7     
  Branches       492      451      -41     
===========================================
+ Hits          6585     6589       +4     
- Misses        3103     3110       +7     
+ Partials        38       34       -4
Impacted Files Coverage Δ
packages/crypto/src/transactions/types/schemas.ts 100% <ø> (ø) ⬆️
packages/crypto/src/transactions/factory.ts 100% <100%> (ø) ⬆️
packages/crypto/src/errors.ts 80.39% <50%> (-1.25%) ⬇️
packages/core-state/src/wallets/wallet.ts 88.04% <75%> (-0.73%) ⬇️
packages/crypto/src/transactions/deserializer.ts 91.2% <85.71%> (-0.75%) ⬇️
packages/core-webhooks/src/conditions.ts 100% <0%> (ø) ⬆️
packages/core-api/src/handlers/utils.ts 74.07% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1016bd5...69dd918. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #2889 into develop will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2889      +/-   ##
===========================================
- Coverage     67.7%   67.69%   -0.01%     
===========================================
  Files          405      405              
  Lines         9726     9733       +7     
  Branches       492      451      -41     
===========================================
+ Hits          6585     6589       +4     
- Misses        3103     3110       +7     
+ Partials        38       34       -4
Impacted Files Coverage Δ
packages/crypto/src/transactions/types/schemas.ts 100% <ø> (ø) ⬆️
packages/crypto/src/transactions/factory.ts 100% <100%> (ø) ⬆️
packages/crypto/src/errors.ts 80.39% <50%> (-1.25%) ⬇️
packages/core-state/src/wallets/wallet.ts 88.04% <75%> (-0.73%) ⬇️
packages/crypto/src/transactions/deserializer.ts 91.2% <85.71%> (-0.75%) ⬇️
packages/core-webhooks/src/conditions.ts 100% <0%> (ø) ⬆️
packages/core-api/src/handlers/utils.ts 74.07% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1016bd5...69dd918. Read the comment docs.

@faustbrian faustbrian merged commit 76f1f41 into develop Aug 25, 2019
@ghost ghost deleted the fix/crypto/multisig-participants branch August 25, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants