refactor(crypto): split the Crypto class into Hash and Transaction #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
The ci/circleci: test-node11-unit job is failing as of 3085faaf64fc67f1c0ef9621fa30b49341c241a6. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
At the moment the
crypto/crypto.tshandles transactions, identities and hashes. This PR splits those up into a newHashclass, removes the identity related methods and moves transaction methods intoTransactions.Transaction.Types of changes
Checklist