Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-api): return wallet vote on v2 endpoints #2009

Merged
merged 3 commits into from
Jan 22, 2019

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Jan 22, 2019

Proposed changes

This helps reduce load on client applications when dealing with many wallets (E.g. the desktop and mobile wallets).

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #2009 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2009   +/-   ##
=======================================
  Coverage     71.2%   71.2%           
=======================================
  Files          386     386           
  Lines         8329    8329           
  Branches      1211    1211           
=======================================
  Hits          5931    5931           
  Misses        2364    2364           
  Partials        34      34
Impacted Files Coverage Δ
...ges/core-api/src/versions/2/wallets/transformer.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a9f86...94bd4ec. Read the comment docs.

@faustbrian faustbrian changed the title feat: return wallet vote on v2 endpoints feat(core-api): return wallet vote on v2 endpoints Jan 22, 2019
@faustbrian faustbrian merged commit 7d6125c into develop Jan 22, 2019
@faustbrian faustbrian deleted the feat/v2-api-wallet-vote branch January 22, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants