Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-database): ensure that delegate search deals with "undefined" as username #1831

Merged
merged 5 commits into from
Dec 18, 2018

Conversation

j-a-m-l
Copy link
Contributor

@j-a-m-l j-a-m-l commented Dec 17, 2018

Proposed changes

Searching delegates without parameters return the delegate with username "undefined" when it should not return anything.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@ghost ghost assigned j-a-m-l Dec 17, 2018
@ghost ghost added the review label Dec 17, 2018
@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #1831 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1831      +/-   ##
===========================================
+ Coverage    39.68%   39.73%   +0.05%     
===========================================
  Files          354      354              
  Lines         7691     7693       +2     
  Branches      1086     1113      +27     
===========================================
+ Hits          3052     3057       +5     
+ Misses        4627     4622       -5     
- Partials        12       14       +2
Impacted Files Coverage Δ
...ckages/core-database/src/repositories/delegates.ts 72.41% <100%> (+2.04%) ⬆️
packages/core-deployer/src/utils.ts 0% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 0% <0%> (ø) ⬆️
packages/crypto/src/utils/sort-transactions.ts 90.9% <0%> (+27.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff9c15...4aee2e8. Read the comment docs.

@j-a-m-l j-a-m-l changed the title fix(core-database): ensure that delegate search deals with "undefined" as username [WIP] fix(core-database): ensure that delegate search deals with "undefined" as username Dec 17, 2018
@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Dec 17, 2018

Other search endpoints return all the results when no parameter is passed, so I've updated this fix to make it consistent

@j-a-m-l j-a-m-l changed the title [WIP] fix(core-database): ensure that delegate search deals with "undefined" as username fix(core-database): ensure that delegate search deals with "undefined" as username Dec 17, 2018
@ghost ghost assigned faustbrian Dec 18, 2018
@faustbrian faustbrian merged commit 8c9b323 into develop Dec 18, 2018
@faustbrian faustbrian deleted the fix-undefined-delegate-search branch December 18, 2018 03:31
@ghost ghost removed the review label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants