fix(core-transaction-pool): pass correct transaction data #1564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Passing
transaction
towallet.canApply
is wrong, as the timestamp is modified by the Block constructor to match its own timestamp. We need to passtransaction.data
as we only have here the unmodified timestamp which was used to calculate the signature(s).Second signature transactions no longer cause a double spend error.
Types of changes
Checklist