fix: htlc refund handler to use performGenericWalletChecks (+ fix e2e…

… tests) (#2944) * test: fix htlc e2e tests * fix: htlc refund tx handler use performGenericWalletChecks instead of super.throwIfCannotBeApplied
ArkEcosystem · Sep 19, 2019 · ec2002d · ec2002d
1 parent 2334cd2
commit ec2002d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/__tests__/e2e/tests/scenarios/scenario1/htlc-claim/1.create-lock-txs.action.js b/__tests__/e2e/tests/scenarios/scenario1/htlc-claim/1.create-lock-txs.action.js
@@ -77,7 +77,7 @@ module.exports = async options => {
                 secretHash: Crypto.HashAlgorithms.sha256(utils.htlcRecipient4.address.slice(0, 32)).toString("hex"),
                 expiration: {
                     type: 2,
-                    value: lastHeight + 1,
+                    value: lastHeight + 4,
                 },
             },
             utils.htlcRecipient4.address,

diff --git a/__tests__/e2e/tests/scenarios/scenario1/htlc-refund/1.create-lock-txs.action.js b/__tests__/e2e/tests/scenarios/scenario1/htlc-refund/1.create-lock-txs.action.js
@@ -26,7 +26,7 @@ module.exports = async options => {
                 secretHash: Crypto.HashAlgorithms.sha256(utils.htlcRecipient1.address.slice(0, 32)).toString("hex"),
                 expiration: {
                     type: 2,
-                    value: lastHeight + 1,
+                    value: lastHeight + 4,
                 },
             },
             utils.htlcRecipient1.address,
@@ -42,7 +42,7 @@ module.exports = async options => {
                 secretHash: Crypto.HashAlgorithms.sha256(utils.htlcRecipient2.address.slice(0, 32)).toString("hex"),
                 expiration: {
                     type: 2,
-                    value: lastHeight + 1,
+                    value: lastHeight + 4,
                 },
             },
             utils.htlcRecipient2.address,

diff --git a/packages/core-transactions/src/handlers/htlc-refund.ts b/packages/core-transactions/src/handlers/htlc-refund.ts
@@ -53,7 +53,7 @@ export class HtlcRefundTransactionHandler extends TransactionHandler {
         sender: State.IWallet,
         databaseWalletManager: State.IWalletManager,
     ): Promise<void> {
-        await super.throwIfCannotBeApplied(transaction, sender, databaseWalletManager);
+        await this.performGenericWalletChecks(transaction, sender, databaseWalletManager);
 
         // Specific HTLC refund checks
         const refundAsset: Interfaces.IHtlcRefundAsset = transaction.data.asset.refund;