fix(core-transactions): throw if transaction key is already tak… (#3095)

ArkEcosystem · Nov 21, 2019 · eaadddc · eaadddc
1 parent b96bb49
commit eaadddc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/crypto/src/errors.ts b/packages/crypto/src/errors.ts
@@ -106,6 +106,12 @@ export class TransactionAlreadyRegisteredError extends CryptoError {
     }
 }
 
+export class TransactionKeyAlreadyRegisteredError extends CryptoError {
+    constructor(name: string) {
+        super(`Transaction key ${name} is already registered.`);
+    }
+}
+
 export class CoreTransactionTypeGroupImmutableError extends CryptoError {
     constructor() {
         super(`The Core transaction type group is immutable.`);

diff --git a/packages/crypto/src/transactions/registry.ts b/packages/crypto/src/transactions/registry.ts
@@ -2,6 +2,7 @@ import { TransactionTypeGroup } from "../enums";
 import {
     CoreTransactionTypeGroupImmutableError,
     TransactionAlreadyRegisteredError,
+    TransactionKeyAlreadyRegisteredError,
     UnkownTransactionError,
 } from "../errors";
 import { validator } from "../validation";
@@ -60,6 +61,10 @@ class TransactionRegistry {
             throw new TransactionAlreadyRegisteredError(constructor.name);
         }
 
+        if (Array.from(this.transactionTypes.values()).some(({ key }) => key === constructor.key)) {
+            throw new TransactionKeyAlreadyRegisteredError(constructor.key);
+        }
+
         this.transactionTypes.set(internalType, constructor);
         this.updateSchemas(constructor);
     }