refactor(core-kernel): rename enable/disableWhen to boot/disposeWhen

ArkEcosystem · Nov 13, 2019 · 83c56f1 · 83c56f1
1 parent 8ca9000
commit 83c56f1
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 14 deletions.
diff --git a/__tests__/unit/core-kernel/bootstrap/service-providers/__stubs__/service-providers.ts b/__tests__/unit/core-kernel/bootstrap/service-providers/__stubs__/service-providers.ts
@@ -179,11 +179,11 @@ export class DeferredServiceProvider extends ServiceProvider {
         return "version";
     }
 
-    public async enableWhen(): Promise<boolean> {
+    public async bootWhen(): Promise<boolean> {
         return process.env.DEFFERED_ENABLE === "true";
     }
 
-    public async disableWhen(): Promise<boolean> {
+    public async disposeWhen(): Promise<boolean> {
         return process.env.DEFFERED_DISABLE === "true";
     }
 }
diff --git a/__tests__/unit/core-kernel/bootstrap/service-providers/boot-service-providers.test.ts b/__tests__/unit/core-kernel/bootstrap/service-providers/boot-service-providers.test.ts
@@ -84,7 +84,7 @@ describe("BootServiceProviders", () => {
         expect(serviceProviderRepository.deferred("stub")).toBeTrue();
     });
 
-    describe("DeferredServiceProvider - enableWhen", () => {
+    describe("DeferredServiceProvider - bootWhen", () => {
         it("should react to [StateEvent.BlockApplied]", async () => {
             const serviceProvider: ServiceProvider = new DeferredServiceProvider();
             const spyBoot = jest.spyOn(serviceProvider, "boot");
@@ -146,7 +146,7 @@ describe("BootServiceProviders", () => {
         });
     });
 
-    describe("DeferredServiceProvider - disableWhen", () => {
+    describe("DeferredServiceProvider - disposeWhen", () => {
         it("should react to [StateEvent.BlockApplied]", async () => {
             const serviceProvider: ServiceProvider = new DeferredServiceProvider();
             const spyDispose = jest.spyOn(serviceProvider, "dispose");

diff --git a/__tests__/unit/core-kernel/providers/service-provider.test.ts b/__tests__/unit/core-kernel/providers/service-provider.test.ts
@@ -132,12 +132,12 @@ describe("ServiceProvider", () => {
         expect(app.resolve(StubServiceProvider).dependencies()).toEqual([]);
     });
 
-    it(".enableWhen", async () => {
-        await expect(app.resolve(StubServiceProvider).enableWhen()).resolves.toBeTrue();
+    it(".bootWhen", async () => {
+        await expect(app.resolve(StubServiceProvider).bootWhen()).resolves.toBeTrue();
     });
 
-    it(".disableWhen", async () => {
-        await expect(app.resolve(StubServiceProvider).disableWhen()).resolves.toBeFalse();
+    it(".disposeWhen", async () => {
+        await expect(app.resolve(StubServiceProvider).disposeWhen()).resolves.toBeFalse();
     });
 
     it(".required", () => {

diff --git a/packages/core-kernel/src/bootstrap/service-providers/boot-service-providers.ts b/packages/core-kernel/src/bootstrap/service-providers/boot-service-providers.ts
@@ -40,7 +40,7 @@ export class BootServiceProviders implements Bootstrapper {
 
             assert.defined<string>(serviceProviderName);
 
-            if (await serviceProvider.enableWhen()) {
+            if (await serviceProvider.bootWhen()) {
                 try {
                     await serviceProviders.boot(name);
                 } catch (error) {
@@ -56,7 +56,7 @@ export class BootServiceProviders implements Bootstrapper {
                 serviceProviders.defer(name);
             }
 
-            // Register the "enable/disableWhen" listeners to be triggered on every block. Use with care!
+            // Register the "enable/disposeWhen" listeners to be triggered on every block. Use with care!
             this.app.events.listen(
                 StateEvent.BlockApplied,
                 async () => await this.changeState(name, serviceProvider, serviceProviders),
@@ -80,12 +80,12 @@ export class BootServiceProviders implements Bootstrapper {
             return;
         }
 
-        if (serviceProviders.loaded(name) && (await serviceProvider.disableWhen())) {
+        if (serviceProviders.loaded(name) && (await serviceProvider.disposeWhen())) {
             await serviceProviders.dispose(name);
         }
 
         /* istanbul ignore else */
-        if (serviceProviders.deferred(name) && (await serviceProvider.enableWhen())) {
+        if (serviceProviders.deferred(name) && (await serviceProvider.bootWhen())) {
             await serviceProviders.boot(name);
         }
     }

diff --git a/packages/core-kernel/src/providers/service-provider.ts b/packages/core-kernel/src/providers/service-provider.ts
@@ -190,7 +190,7 @@ export abstract class ServiceProvider {
      * @returns {Promise<boolean>}
      * @memberof ServiceProvider
      */
-    public async enableWhen(): Promise<boolean> {
+    public async bootWhen(): Promise<boolean> {
         return true;
     }
 
@@ -200,7 +200,7 @@ export abstract class ServiceProvider {
      * @returns {Promise<boolean>}
      * @memberof ServiceProvider
      */
-    public async disableWhen(): Promise<boolean> {
+    public async disposeWhen(): Promise<boolean> {
         return false;
     }