fix(core-p2p): replace ws connection logging method (#3791)

__tests__/unit/core-p2p/peer-connector.test.ts

@@ -9,12 +9,17 @@ import { NesClient } from "./mocks/nes";
 
 jest.mock("@hapi/nes", () => require("./mocks/nes"));
 
+
 describe("PeerConnector", () => {
     let peerConnector: PeerConnector;
+    let logger;
 
     beforeEach(() => {
+        logger = { warning: jest.fn(), debug: jest.fn(), error: jest.fn(), info: jest.fn() };
+
         const container = new Container.Container();
         container.unbindAll();
+        container.bind(Container.Identifiers.LogService).toConstantValue(logger);
         container.bind(Container.Identifiers.PeerConnector).to(PeerConnector);
 
         peerConnector = container.get<PeerConnector>(Container.Identifiers.PeerConnector);
@@ -58,6 +63,16 @@ describe("PeerConnector", () => {
             expect(peerConnection).toBeInstanceOf(NesClient);
             expect(peerConnection).toBe(peerConnector.connection(peer));
         });
+
+        it("should log if error on connection", async () => {
+            const peer = new Peer("178.165.55.11", 4000);
+            const peerConnection = await peerConnector.connect(peer);
+
+            peerConnection.onError(new Error("dummy"));
+
+            expect(peerConnection).toBeInstanceOf(NesClient);
+            expect(logger.debug).toHaveBeenCalled();
+        });
     });
 
     describe("disconnect", () => {

packages/core-p2p/src/peer-connector.ts

@@ -4,6 +4,9 @@ import Nes from "@hapi/nes";
 // todo: review the implementation
 @Container.injectable()
 export class PeerConnector implements Contracts.P2P.PeerConnector {
+    @Container.inject(Container.Identifiers.LogService)
+    private readonly logger!: Contracts.Kernel.Logger;
+
     private readonly connections: Map<string, Nes.Client> = new Map<string, Nes.Client>();
     private readonly errors: Map<string, string> = new Map<string, string>();
 
@@ -65,6 +68,11 @@ export class PeerConnector implements Contracts.P2P.PeerConnector {
 
     private async create(peer: Contracts.P2P.Peer): Promise<Nes.Client> {
         const connection = new Nes.Client(`ws://${peer.ip}:${peer.port}`);
+
+        connection.onError = (error) => {
+            this.logger.debug(`Socket error (peer ${peer.ip}) : ${error.message}`);
+        };
+
         await connection.connect();
 
         return connection;