Skip to content

Add techtenstein.com: color-palette, timezone-convert, password-strength#2840

Open
sathvic-kollu wants to merge 3 commits into
APIs-guru:mainfrom
techtenstein-labs:add-techtenstein-apis
Open

Add techtenstein.com: color-palette, timezone-convert, password-strength#2840
sathvic-kollu wants to merge 3 commits into
APIs-guru:mainfrom
techtenstein-labs:add-techtenstein-apis

Conversation

@sathvic-kollu

Copy link
Copy Markdown

Adds 3 OpenAPI 3.1 specs for free, zero-key APIs at techtenstein.com.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces three new OpenAPI 3.1.0 specifications for Techtenstein's Color Palette, Password Strength, and Timezone Convert APIs. The review highlights a critical security risk in the Password Strength API where sensitive passwords are sent via query parameters instead of a secure request body. Additionally, across all three specifications, multiple endpoints are missing response content definitions and schemas for successful 200 responses, which are necessary for proper API documentation and client SDK generation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +27 to +34
get:
summary: Score a password
parameters:
- name: password
in: query
required: true
schema:
type: string

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

Passing sensitive information like passwords in query parameters (in: query) is a significant security risk. Query parameters are frequently logged by web servers, reverse proxies, CDNs, and browser history. If the underlying API supports it, this endpoint should be changed to a POST request with the password sent securely in the request body. If the API is external and cannot be changed, please document this security risk in the description.

Comment on lines +83 to +84
'200':
description: Palette

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The response for the 200 status code is missing a content definition. To make the OpenAPI specification complete and useful for client generation, please define the media type (e.g., application/json) and the corresponding schema. Note that this issue also affects other endpoints in this file, such as /convert, /contrast, and /health.

        '200':
          description: Palette
          content:
            application/json:
              schema:
                type: object

Comment on lines +49 to +50
'200':
description: Converted time

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The response for the 200 status code is missing a content definition. Defining the response schema is essential for client SDK generation and API documentation. Note that this issue also affects other endpoints in this file, such as /now, /offset, /diff, /zones, and /health.

        '200':
          description: Converted time
          content:
            application/json:
              schema:
                type: object

Comment on lines +67 to +68
'200':
description: Passwords

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The response for the 200 status code is missing a content definition. Please specify the response media type and schema. Note that this issue also affects other endpoints in this file, such as /passphrase and /health.

        '200':
          description: Passwords
          content:
            application/json:
              schema:
                type: object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant