fix: exclude paths before resolving references - #431
Merged
Conversation
Coverage Report for CI Build 32931149273Coverage decreased (-0.4%) to 89.447%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #429
Alternative implementation to #430.
Summary
resolveExcludedPathMatcher(path, value)so callers can leave literal$refdata untouched before resolution fetches it$idaliases, shared documents, cycles, and extended-reference merges$RefsinventoryAPI placement
The issue sketch places the callback at
resolve.excludedPathMatcher. Theresolveobject is also an open string-keyed map of custom resolver plugins, so adding a function there widens every resolver entry to accept bare functions and weakens existing narrowing. TypeScript cannot subtract one literal key from a string index signature.This implementation therefore uses the top-level
resolveExcludedPathMatcheroption. Passing the nested form at runtime throws an actionable error instead of being silently treated as a resolver plugin. The exportedExcludedPathMatchertype is shared by resolution, bundling, and dereferencing.Verification
pnpm buildpnpm typecheck(library plus consumer-facing option fixtures)pnpm lintpnpm exec oxfmt --check "**/*.{js,jsx,ts,tsx,har,json,css,md}"git diff --checkThe typecheck is also added to CI so the resolver-map regression remains covered.