drm/rockchip: dw_hdmi: use correct SCLIN mask for RK3228

aloktiwa · mmind · commit c700e7279b29 · 2025-10-16T17:57:50.000+02:00
In dw_hdmi_rk3228_setup_hpd(), the SCLIN mask incorrectly references the RK3328 variant. This change updates it to the RK3228-specific mask RK3228_HDMI_SCLIN_MSK using FIELD_PREP_WM16, ensuring proper HPD and I2C pin configuration for RK3228. Change: RK3328_HDMI_SCLIN_MSK -> RK3228_HDMI_SCLIN_MSK Fixes: 63df37f ("drm/rockchip: dw_hdmi: switch to FIELD_PREP_WM16* macros") Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com> Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Link: https://lore.kernel.org/r/20251010173143.72733-1-alok.a.tiwari@oracle.com
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -361,7 +361,7 @@ static void dw_hdmi_rk3228_setup_hpd(struct dw_hdmi *dw_hdmi, void *data)
 
 	regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2,
 		     FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) |
-		     FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1));
+		     FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1));
 }
 
 static enum drm_connector_status

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ static void dw_hdmi_rk3228_setup_hpd(struct dw_hdmi dw_hdmi, void data)`
`361`	`361`
`362`	`362`	`regmap_write(hdmi->regmap, RK3228_GRF_SOC_CON2,`
`363`	`363`	`FIELD_PREP_WM16(RK3228_HDMI_SDAIN_MSK, 1) \|`
`364`		`- FIELD_PREP_WM16(RK3328_HDMI_SCLIN_MSK, 1));`
	`364`	`+ FIELD_PREP_WM16(RK3228_HDMI_SCLIN_MSK, 1));`
`365`	`365`	`}`
`366`	`366`
`367`	`367`	`static enum drm_connector_status`