Skip to content

Commit 243cb09

Browse files
committed
8327389: Remove use of HOTSPOT_BUILD_USER
Reviewed-by: erikj, ihse
1 parent 2d4c757 commit 243cb09

File tree

5 files changed

+2
-10
lines changed

5 files changed

+2
-10
lines changed

make/hotspot/lib/CompileJvm.gmk

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ CFLAGS_VM_VERSION := \
7373
$(VERSION_CFLAGS) \
7474
-DHOTSPOT_VERSION_STRING='"$(VERSION_STRING)"' \
7575
-DDEBUG_LEVEL='"$(DEBUG_LEVEL)"' \
76-
-DHOTSPOT_BUILD_USER='"$(USERNAME)"' \
7776
-DHOTSPOT_VM_DISTRO='"$(HOTSPOT_VM_DISTRO)"' \
7877
-DCPU='"$(OPENJDK_TARGET_CPU_VM_VERSION)"' \
7978
-DHOTSPOT_BUILD_TIME='"$(HOTSPOT_BUILD_TIME)"' \

make/ide/eclipse/CreateWorkspace.gmk

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,15 +280,13 @@ define SetupEclipseWorkspaceBody
280280
<resource project-relative-path="src/hotspot/share/runtime/abstract_vm_version.cpp"> \
281281
<entry kind="macro" name="HOTSPOT_VERSION_STRING" value="&quot;$(VERSION_STRING)&quot;"/> \
282282
<entry kind="macro" name="DEBUG_LEVEL" value="&quot;$(DEBUG_LEVEL)&quot;"/> \
283-
<entry kind="macro" name="HOTSPOT_BUILD_USER" value="&quot;$(USERNAME)&quot;"/> \
284283
<entry kind="macro" name="HOTSPOT_VM_DISTRO" value="&quot;$(HOTSPOT_VM_DISTRO)&quot;"/> \
285284
<entry kind="macro" name="CPU" value="&quot;$(OPENJDK_TARGET_CPU_VM_VERSION)&quot;"/> \
286285
<entry kind="macro" name="HOTSPOT_BUILD_TIME" value="&quot;$(if $(HOTSPOT_BUILD_TIME),$(HOTSPOT_BUILD_TIME),$(call EpochToISO8601,$(shell $(DATE) +"%s")))&quot;"/> \
287286
</resource> \
288287
<resource project-relative-path="src/hotspot/share/runtime/arguments.cpp"> \
289288
<entry kind="macro" name="HOTSPOT_VERSION_STRING" value="&quot;$(VERSION_STRING)&quot;"/> \
290289
<entry kind="macro" name="DEBUG_LEVEL" value="&quot;$(DEBUG_LEVEL)&quot;"/> \
291-
<entry kind="macro" name="HOTSPOT_BUILD_USER" value="&quot;$(USERNAME)&quot;"/> \
292290
<entry kind="macro" name="HOTSPOT_VM_DISTRO" value="&quot;$(HOTSPOT_VM_DISTRO)&quot;"/> \
293291
<entry kind="macro" name="CPU" value="&quot;$(OPENJDK_TARGET_CPU_VM_VERSION)&quot;"/> \
294292
<entry kind="macro" name="HOTSPOT_BUILD_TIME" value="&quot;$(if $(HOTSPOT_BUILD_TIME),$(HOTSPOT_BUILD_TIME),$(call EpochToISO8601,$(shell $(DATE) +"%s")))&quot;"/> \

make/ide/visualstudio/hotspot/src/classes/build/tools/projectcreator/BuildConfig.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ void initDefaultDefines(Vector defines) {
221221
Vector sysDefines = new Vector();
222222
sysDefines.add("WIN32");
223223
sysDefines.add("_WINDOWS");
224-
sysDefines.add("HOTSPOT_BUILD_USER=\\\""+System.getProperty("user.name")+"\\\"");
225224
sysDefines.add("HOTSPOT_BUILD_TARGET=\\\""+get("Build")+"\\\"");
226225
sysDefines.add("INCLUDE_JFR=1");
227226
sysDefines.add("_JNI_IMPLEMENTATION_");

make/ide/visualstudio/hotspot/src/classes/build/tools/projectcreator/ProjectCreator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public static void usage() {
7878
System.err.println(" are both quoted strings.");
7979
System.err.println(" Default includes: \".\"");
8080
System.err
81-
.println(" Default defines: WIN32, _WINDOWS, \"HOTSPOT_BUILD_USER=$(USERNAME)\"");
81+
.println(" Default defines: WIN32, _WINDOWS");
8282
}
8383

8484
public static void main(String[] args) {

src/hotspot/share/runtime/abstract_vm_version.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,6 @@ const char *Abstract_VM_Version::vm_platform_string() {
197197
}
198198

199199
const char* Abstract_VM_Version::internal_vm_info_string() {
200-
#ifndef HOTSPOT_BUILD_USER
201-
#define HOTSPOT_BUILD_USER unknown
202-
#endif
203-
204200
#ifndef HOTSPOT_BUILD_COMPILER
205201
#ifdef _MSC_VER
206202
#if _MSC_VER == 1911
@@ -284,7 +280,7 @@ const char* Abstract_VM_Version::internal_vm_info_string() {
284280
#define INTERNAL_VERSION_SUFFIX VM_RELEASE ")" \
285281
" for " OS "-" CPU FLOAT_ARCH_STR LIBC_STR \
286282
" JRE (" VERSION_STRING "), built on " HOTSPOT_BUILD_TIME \
287-
" by " XSTR(HOTSPOT_BUILD_USER) " with " HOTSPOT_BUILD_COMPILER
283+
" with " HOTSPOT_BUILD_COMPILER
288284

289285
return strcmp(DEBUG_LEVEL, "release") == 0
290286
? VMNAME " (" INTERNAL_VERSION_SUFFIX

0 commit comments

Comments
 (0)