Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage CI. #2541

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add code coverage CI. #2541

merged 1 commit into from
Jan 7, 2025

Conversation

maryla-uc
Copy link
Collaborator

Add a cmake option.
Document in readme.

After this is merged I will delete the seriously outdated instructions in the wiki https://github.com/AOMediaCodec/libavif/wiki/Coverage

Add a cmake option.
Document in readme.
@maryla-uc
Copy link
Collaborator Author

Note the CI is not strictly required, but it makes sure the coverage stuff actually works, and uploads the coverage report as a github artifact that can be downloaded e.g. here https://github.com/AOMediaCodec/libavif/actions/runs/12584719944?pr=2541

@vrabaud
Copy link
Collaborator

vrabaud commented Jan 2, 2025

We could also upload those to https://app.codecov.io/ . and have a little badge on top of our README.

@maryla-uc
Copy link
Collaborator Author

Indeed, that looks nice! I think it can be done as a second step (in another PR).

@maryla-uc maryla-uc merged commit 0def9e5 into AOMediaCodec:main Jan 7, 2025
35 checks passed
@maryla-uc
Copy link
Collaborator Author

I tried setting up codecov.io but I think you need to be a member of the AOMediaCodec organization?
Basically you need to log into codecov.io with your github account, and it should show a list of github repos you can configure. But in my case it only shows my own fork of libavif (among other forks I have), not AOMediaCodec/libavif. @wantehchang would you have the necessary permissions to set it up? See their quick start guide: https://docs.codecov.com/docs/quick-start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants